Stop passing CMAKE_TOOLCHAIN_FILE, append to CMAKE_FIND_ROOT_PATH#291
Stop passing CMAKE_TOOLCHAIN_FILE, append to CMAKE_FIND_ROOT_PATH#291mgorny wants to merge 2 commits into
Conversation
Stop passing obsolete CMAKE_TOOLCHAIN_FILE for CPU builds. Instead, append the source directory to CMAKE_FIND_ROOT_PATH directly. Do that unconditionally, to improve consistency between CPU and GPU builds, and hopefully make it possible to build MKLDNN with CUDA enabled.
…nda-forge-pinning 2024.11.18.19.00.37
|
And thanks to @isuruf for explaining the toolchain thing to me. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
If this is the case, I would rather you set the time limit to 1 min to effectively force the CI to not publish at all. I am a little concerned about the GPU build since it doesn't show up on the CIs. |
I'm sorry, I didn't know I can do that. In fact, I haven't found any information on that yet. Perhaps I could use Also, I'm currently confirming that this fixes |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)I haven't bumped the build number since this shouldn't be changing anything (and at least at a first glance, I didn't notice any differences). It's getting late today, so I'm going to look at whether this actually fixes building against vendored mkldnn tomorrow (I've originally tested only against my system-mkldnn branch).