Triton bump, py3.14 + CUDA 13.0#477
Conversation
Signed-off-by: Michał Górny <mgorny@quansight.com>
CUDA 13.0 requires architecture `sm_75` or higher, and renamed `sm_101` to `sm_110`. To build for these, maintainers will need to modify their existing list of specified architectures (e.g. `CMAKE_CUDA_ARCHITECTURES`, `TORCH_CUDA_ARCH_LIST`, etc.) for their package. Since CUDA 12.8, the conda-forge nvcc package now sets `CUDAARCHS` and in its activation script to a string containing all of the supported real architectures plus the virtual architecture of the latest. Recipes for packages who use these variables to control their build but do not want to build for all supported architectures will need to override these variables in their build script. ref: https://docs.nvidia.com/cuda/cuda-toolkit-release-notes/index.html#new-features > [[!IMPORTANT]] > Remember to update any CUDA 11/12 specific selector syntax in the recipe to include > CUDA 13. For example `# [(cuda_compiler_version or "None").startswith("12")]` > might be replaced with `# [cuda_compiler_version != "None"]`.
Thanks to @carterbox for the patch: conda-forge#457 (comment) Signed-off-by: Michał Górny <mgorny@quansight.com>
…6.01.26.08.52.07 Other tools: - conda-build 25.11.1 - rattler-build 0.55.1 - rattler-build-conda-compat 1.4.10
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/21452160226. Examine the logs at this URL for more detail. |
|
Reminder to self: once this is merged, enable triton tests on py3.14. |
|
Minimal test run passed. Now let's do the full thing… |
f5e1df4 to
cfb7619
Compare
|
@mgorny, this is still using GPU agents to build the CPU versions, c.f. my comment from #475
|
jakirkham
left a comment
There was a problem hiding this comment.
Thanks Michał! 🙏
Had a question below about MAGMA usage
Ah, sorry, I was missing #332. Was wondering why git conda-smithy didn't produce any differences, and figure out the relevant changes must've been released already. |
|
Looks like |
Co-Authored-By: Isuru Fernando <isuruf@gmail.com>
…forge-pinning 2026.01.26.08.52.07 Other tools: - conda-build 25.11.1.dev19+dirty - rattler-build 0.55.1 - rattler-build-conda-compat 1.4.10
30514e3 to
e1975df
Compare
|
It looks like we might have a new must-fix issue for any new PRs here: #478 |
Signed-off-by: Michał Górny <mgorny@quansight.com>
Fixes conda-forge#479 Signed-off-by: Michał Górny <mgorny@quansight.com>
|
Added the |
|
Your fix looks obviously correct™️, so I'm going to cancel CI. The server is heavily congested right now, so this has too little marginal benefit IMO. We can merge this without rerunning CI once the congestion has cleared a bit. |
|
OK, flash-attn is through (well, at least has stopped consuming agents), tensorflow is down to one job that's almost done, and while there's a stray webkit still around, that shouldn't stop us from merging this one. Bombs away! |
|
Congrats and great thanks to @mgorny and everyone who helped with this effort! |
|
Not sure where the best place is to report, but in conda-forge/theseus-ai-feedstock#32 I get |
|
Alternatively we could configure downstream feedstocks to wait until the PyTorch packages are available before attempting migration bot:
# only open PRs if resulting environment is solvable, useful for tightly coupled packages
check_solvable: true |
|
I much prefer PRs to be opened even if they don't pass yet. That's infinitely more visible than something lost in the bowels of the bot infrastructure. It's only a minor inconvenience if CI on those PRs has to be restarted, which would have been nice to avoid, but it's ultimately not a big deal IMO. |
|
win+CUDA12.8: $ gh run download 21475924468 --repo conda-forge/pytorch-cpu-feedstock --name conda_artifacts_21475924468_win_64_channel_targetsconda-forge_maincu_hca575dce
$ unzip pytorch-cpu-feedstock_conda_artifacts_.zip
$ cd bld/win-64 && rm current_repodata.json index.html repodata*
$ ls
libtorch-2.10.0-cuda128_mkl_h97e3598_301.conda pytorch-gpu-2.10.0-cuda128_mkl_hc88b545_301.conda
pytorch-2.10.0-cuda128_mkl_py310_hdd2a298_301.conda pytorch-tests-2.10.0-cuda128_mkl_py310_hf0eca92_301.conda
pytorch-2.10.0-cuda128_mkl_py311_h0cb71aa_301.conda pytorch-tests-2.10.0-cuda128_mkl_py311_hc85c64c_301.conda
pytorch-2.10.0-cuda128_mkl_py312_hc4f88d7_301.conda pytorch-tests-2.10.0-cuda128_mkl_py312_hb3d0777_301.conda
pytorch-2.10.0-cuda128_mkl_py313_h716786b_301.conda pytorch-tests-2.10.0-cuda128_mkl_py313_hd85d54a_301.conda
pytorch-2.10.0-cuda128_mkl_py314_hc058aa6_301.conda pytorch-tests-2.10.0-cuda128_mkl_py314_hfe9566a_301.conda
$ ls | xargs anaconda upload
$ DELEGATE=h-vetinari
PACKAGE_VERSION=2.10.0
for package in libtorch pytorch pytorch-gpu pytorch-tests; do
anaconda copy --from-label main --to-label main --to-owner conda-forge ${DELEGATE}/${package}/${PACKAGE_VERSION}
doneThe CUDA 13.0 build failed due to losing connection with the agent; if we're lucky the reduction in GPU arches means that libtorch will be small enough to succeed uploading upon restart. |
|
Obviously, with an extra python version to build & test for I also noticed that the |
|
I suppose we could start considering removing some of the targets common to CUDA 12.x and 13.x, but we probably need to be careful (though I think PTX should make this less harmful?) |
|
Perhaps this would be worth discussing in a new issue? |
|
Feel free to open an issue! |
|
All builds are online now. I've just started CI for d392c50, which is the backport of the CMake fix to |
Closes #296 Restores CUDA 13 conda test CI jobs, now that there are conda-forge PyTorch packages with CUDA 13 support (conda-forge/pytorch-cpu-feedstock#477) Also modifies `pytorch` conda dependency to meet these requirements: * `cugraph-pyg` must be installable on a system without a GPU * `cugraph-pyg`'s tests require CUDA-enabled builds of PyTorch With the following mix of things: * add a `require_gpu` matrix filter in `dependencies.yaml` which pulls in `pytorch-gpu` opted-into in test CI jobs but otherwise not - *`conda-forge::pytorch-gpu` is a metapackage that forces the installation of CUDA variants of `conda-forge::pytorch`... that should replace the "accidentally pulled in a CPU-only variant" case with a loud, clear conda solver error* * depend on `mkl` in the test x86_64 environment but without version constraints - *allow `pytorch` to declare its range of compatible `mkl` versions* - *this still prevents OpenBLAS variants from getting installed, which I think was part of the goal of #161* - *keeping this out of `cugraph-pyg`'s dependencies still makes it possible to install alongside `nomkl`, even though that combination is untested* * add comments in the `cugraph-pyg` conda recipe explaining why it doesn't depend on `pytorch-gpu` I hope this will be a relatively future-proof way to guarantee CI here keeps picking up the PyTorch versions this project wants to tet against. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Alex Barghi (https://github.com/alexbarghi-nv) - Bradley Dice (https://github.com/bdice) URL: #395
There are now `pytorch` CUDA 13 packages (started with `pytorch` 2.10: conda-forge/pytorch-cpu-feedstock#477) This adds them to the test environment so they'll be tested in CUDA 13 integration testing jobs. More details on the history of PyTorch in those jobs: #20748 (comment) Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #21663
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Fixes #457
Fixes #420