Fix initialize_conda for boolean values (#1032)

* Set initialize_conda to classic when True

* Add additional type check for Windows variables

* Add tests for boolean initialize_conda values

* Add news

* Fix evaluation order of initialization tests

Author: marcoesters

constructor/main.py

@@ -265,6 +265,8 @@ def main_build(
     if initialize_conda := info.get("initialize_conda"):
         if not info.get("_has_conda"):
             sys.exit("Error: 'initialize_conda' requires 'conda' in the base environment.")
+        if initialize_conda is True:
+            info["initialize_conda"] = "classic"
         if initialize_conda == "condabin" and platform.startswith(("linux-", "osx-")):
             conda = next(record for record in info.get("_records", ()) if record.name == "conda")
             if Version(conda.version) < Version("25.5.0"):

constructor/winexe.py

@@ -217,7 +217,7 @@ def make_nsi(
                 info[key] = valid_values
 
     for key, value in variables.items():
-        if value.startswith("@"):
+        if isinstance(value, str) and value.startswith("@"):
             value = join(dir_path, value[1:])
         variables[key] = win_str_esc(value)
 

news/1032-initialize-conda-boolean

@@ -0,0 +1,19 @@
+### Enhancements
+
+* <news item>
+
+### Bug fixes
+
+* Re-enable boolean values for `initialize_conda` on Windows. (#1032)
+
+### Deprecations
+
+* <news item>
+
+### Docs
+
+* <news item>
+
+### Other
+
+* <news item>

tests/test_examples.py

@@ -990,15 +990,16 @@ def test_virtual_specs_override(tmp_path, request, monkeypatch):
 
 
 @pytest.mark.skipif(not ON_CI, reason="Run on CI only")
-@pytest.mark.parametrize("method", ("classic", "condabin"))
+@pytest.mark.parametrize("method", ("classic", "condabin", True, False))
 def test_initialization(tmp_path, request, monkeypatch, method):
     request.addfinalizer(
         lambda: subprocess.run([sys.executable, "-m", "conda", "init", "--reverse"])
     )
     monkeypatch.setenv("initialization_method", method)
     input_path = _example_path("initialization")
+    initialize = method is not False
     for installer, install_dir in create_installer(input_path, tmp_path):
-        if installer.suffix == ".sh":
+        if installer.suffix == ".sh" and initialize:
             options = ["-c"]
         elif installer.suffix == ".exe":
             # GHA runs on an admin user account, but AllUsers (admin) installs
@@ -1031,11 +1032,11 @@ def test_initialization(tmp_path, request, monkeypatch, method):
                         value = winreg.QueryValueEx(key, "PATH")[0]
                         paths += value.strip().split(os.pathsep)
                 if method == "condabin":
-                    assert str(install_dir / "condabin") in paths
+                    assert (str(install_dir / "condabin") in paths) == initialize
                 else:
-                    assert str(install_dir) in paths
-                    assert str(install_dir / "Scripts") in paths
-                    assert str(install_dir / "Library" / "bin") in paths
+                    assert (str(install_dir) in paths) == initialize
+                    assert (str(install_dir / "Scripts") in paths) == initialize
+                    assert (str(install_dir / "Library" / "bin") in paths) == initialize
 
             finally:
                 _run_uninstaller_exe(install_dir, check=True)
@@ -1047,9 +1048,11 @@ def test_initialization(tmp_path, request, monkeypatch, method):
                 text=True,
             )
             if method == "condabin":
-                assert str(install_dir / "condabin") in out.strip().split(os.pathsep)
+                assert (
+                    str(install_dir / "condabin") in out.strip().split(os.pathsep)
+                ) == initialize
             else:
-                assert str(install_dir / "bin") in out.strip().split(os.pathsep)
+                assert (str(install_dir / "bin") in out.strip().split(os.pathsep)) == initialize
 
 
 @pytest.mark.skipif(not ON_CI, reason="CI only")