Skip to content

Add support for mirrored channels#1008

Merged
jaimergp merged 27 commits into
conda:mainfrom
IsabelParedes:channels
Jul 17, 2025
Merged

Add support for mirrored channels#1008
jaimergp merged 27 commits into
conda:mainfrom
IsabelParedes:channels

Conversation

@IsabelParedes
Copy link
Copy Markdown
Contributor

@IsabelParedes IsabelParedes commented Jun 27, 2025 •
edited
Loading

Description

This PR adds a mirrored_channels option to the schema, these mirrored channels are then included in the resulting condarc file if one is created.

Sources:

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@github-project-automation github-project-automation Bot moved this to 🆕 New in 🔎 Review Jun 27, 2025
@conda-bot
Copy link
Copy Markdown
Contributor

conda-bot commented Jun 27, 2025

We require contributors to sign our Contributor License Agreement and we don't have one on file for @IsabelParedes.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#1172), and ping the bot to refresh the PR.

@conda-bot conda-bot mentioned this pull request Jun 27, 2025
Merged
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jun 27, 2025
@IsabelParedes IsabelParedes marked this pull request as ready for review June 27, 2025 15:41
@IsabelParedes IsabelParedes requested a review from a team as a code owner June 27, 2025 15:41
marcoesters
marcoesters reviewed Jun 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@marcoesters marcoesters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments.

The test failures are unrelated to this PR - this seems to be a problem on the anaconda.org side.

Comment thread constructor/utils.py
Comment thread examples/miniforge-mamba2/construct.yaml Outdated
Comment thread constructor/utils.py Outdated
Comment thread news/1008-mirrored-channels-schema Outdated
@IsabelParedes IsabelParedes marked this pull request as draft June 30, 2025 16:28
@IsabelParedes IsabelParedes marked this pull request as ready for review July 1, 2025 17:27
marcoesters
marcoesters reviewed Jul 2, 2025
View reviewed changes
Comment thread tests/test_examples.py Outdated
@IsabelParedes IsabelParedes marked this pull request as draft July 3, 2025 11:57
@IsabelParedes IsabelParedes marked this pull request as ready for review July 3, 2025 15:51
@marcoesters
Copy link
Copy Markdown
Contributor

marcoesters commented Jul 3, 2025

pre-commit.ci autofix

marcoesters
marcoesters reviewed Jul 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@marcoesters marcoesters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're almost there. The test is testing the right thing, but I have a suggestion on how to make it more robust.

Comment thread tests/test_examples.py Outdated
Comment thread tests/test_examples.py Outdated
@IsabelParedes IsabelParedes marked this pull request as draft July 4, 2025 12:32
@IsabelParedes IsabelParedes marked this pull request as ready for review July 4, 2025 13:14
jaimergp
jaimergp requested changes Jul 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jaimergp jaimergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of fixes needed, but this is going in the right direction!

Comment thread constructor/utils.py Outdated
Comment thread constructor/_schema.py
@github-project-automation github-project-automation Bot moved this from 🆕 New to 🏗️ In Progress in 🔎 Review Jul 4, 2025
@IsabelParedes IsabelParedes marked this pull request as draft July 7, 2025 09:29
@IsabelParedes IsabelParedes marked this pull request as ready for review July 7, 2025 11:16
@IsabelParedes
Copy link
Copy Markdown
Contributor Author

IsabelParedes commented Jul 7, 2025

Thank you for all the feedback! Please let me know if there is anything else missing.

@marcoesters
Copy link
Copy Markdown
Contributor

marcoesters commented Jul 8, 2025

pre-commit.ci autofix

IsabelParedes and others added 20 commits July 9, 2025 11:58
@IsabelParedes
Fix spacing
c5e4ba0
@IsabelParedes
Fix schema formatting
5d6a6ca
@IsabelParedes @marcoesters
Update news/1008-mirrored-channels-schema
672dc7e 
Co-authored-by: Marco Esters <mesters@anaconda.com>
@IsabelParedes
Restore miniforge example
567748b
@IsabelParedes
Add mirrored channels example
8ed69a1
@IsabelParedes
Add mirrored channels to testing
b95aeb1
@IsabelParedes
Improve conditional
4a55c1e
@IsabelParedes @marcoesters
Update tests/test_examples.py
106d034 
Co-authored-by: Marco Esters <mesters@anaconda.com>
@IsabelParedes
Disable uninstalling
c09910b
@IsabelParedes
Update mirrors test
fb702a4
@IsabelParedes
Add warning about mirrors without mamba
8079e29
@IsabelParedes
Add mirrored_channels to or check
fbfd0bc
@pre-commit-ci @IsabelParedes
[pre-commit.ci] auto fixes from pre-commit.com hooks
e733784 
for more information, see https://pre-commit.ci
@IsabelParedes @marcoesters
Assert condarc file exists
9beea02 
Co-authored-by: Marco Esters <mesters@anaconda.com>
@IsabelParedes
Use ruamel.yaml for comparison
ff16514
@IsabelParedes @jaimergp
Improve mamba spec detection
f927060 
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
@IsabelParedes @jaimergp
Include mamba in description
be1758f 
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
@IsabelParedes
Improve description in schema
b862d70
@IsabelParedes
Update docs
ff71523
@pre-commit-ci @IsabelParedes
[pre-commit.ci] auto fixes from pre-commit.com hooks
94525eb 
for more information, see https://pre-commit.ci
IsabelParedes
IsabelParedes commented Jul 9, 2025
View reviewed changes
Comment thread constructor/utils.py
@jaimergp
Copy link
Copy Markdown
Member

jaimergp commented Jul 17, 2025

Amazing, thank you! CI failures are unrelated, will merge whether this re-run works or not.

@github-project-automation github-project-automation Bot moved this from 🏗️ In Progress to ✅ Approved in 🔎 Review Jul 17, 2025
@jaimergp jaimergp merged commit 2a97ab8 into conda:main Jul 17, 2025
41 of 47 checks passed
@github-project-automation github-project-automation Bot moved this from ✅ Approved to 🏁 Done in 🔎 Review Jul 17, 2025
@IsabelParedes IsabelParedes deleted the channels branch July 21, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaimergp jaimergp jaimergp approved these changes

@marcoesters marcoesters marcoesters approved these changes

Assignees

No one assigned

Labels

cla-signed [bot] added once the contributor has signed the CLA

Projects

🔎 Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@IsabelParedes @conda-bot @marcoesters @jaimergp