Fix MSI test for Windows Canary build#1264
Merged
Merged
Conversation
Contributor
Why is this solution preferred over just adding the missing file into |
Contributor
Author
That's a good question and definitely one of the options. I chose this over the other because I didn't want to couple contents of Let me know if you've any preference. |
marcoesters
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates a test that was failing in the Windows canary build https://github.com/conda/constructor/actions/runs/27581405719/job/81677012823.
The issue was that the test was referencing a file (an image in this case) which isn't available because, Canary builds do:
D:\a\constructor\constructor\pkgs\constructor_1781618608424\test_tmp\recipe/meta.yamlsource_filesare copied into this test environmentTherefore, dynamically create a temporary image as part of the test and dont reference the example file. Originally when implementing this I only referenced the image because I just needed any image in order to do the test.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?