Fix AzureSignTool signature verification for paths with spaces#1273
Merged
Conversation
df7cc6e to
d6504b6
Compare
372bc64 to
7262118
Compare
marcoesters
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AzureSignTool.verify_signatureinterpolated the installer path into the PowerShellGet-AuthenticodeSignaturecommand without quoting it. When the path contained a space, PowerShell split it into multiple positional arguments and failed withA positional parameter cannot be found that accepts argument....This is not a new bug but was discovered when trying to add signing of MSI installers to a CI workflow (whose Briefcase output is nested under a
<name> <version>directory - always contains a space).Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?