Skip to content

Fix AzureSignTool signature verification for paths with spaces#1273

Merged
lrandersson merged 3 commits into
conda:mainfrom
lrandersson:dev-ra-signing-issue
Jul 1, 2026
Merged

Fix AzureSignTool signature verification for paths with spaces#1273
lrandersson merged 3 commits into
conda:mainfrom
lrandersson:dev-ra-signing-issue

Conversation

@lrandersson

@lrandersson lrandersson commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Description

AzureSignTool.verify_signature interpolated the installer path into the PowerShell Get-AuthenticodeSignature command without quoting it. When the path contained a space, PowerShell split it into multiple positional arguments and failed with A positional parameter cannot be found that accepts argument....
This is not a new bug but was discovered when trying to add signing of MSI installers to a CI workflow (whose Briefcase output is nested under a <name> <version> directory - always contains a space).

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@lrandersson lrandersson self-assigned this Jun 29, 2026
@lrandersson lrandersson requested a review from a team as a code owner June 29, 2026 13:56
@github-project-automation github-project-automation Bot moved this to 🆕 New in 🔎 Review Jun 29, 2026
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jun 29, 2026
@lrandersson lrandersson force-pushed the dev-ra-signing-issue branch from df7cc6e to d6504b6 Compare June 29, 2026 19:28
@lrandersson lrandersson force-pushed the dev-ra-signing-issue branch from 372bc64 to 7262118 Compare June 30, 2026 18:33
@github-project-automation github-project-automation Bot moved this from 🆕 New to ✅ Approved in 🔎 Review Jul 1, 2026
@lrandersson lrandersson merged commit af19c3f into conda:main Jul 1, 2026
33 of 34 checks passed
@github-project-automation github-project-automation Bot moved this from ✅ Approved to 🏁 Done in 🔎 Review Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed [bot] added once the contributor has signed the CLA

Projects

Status: 🏁 Done

Development

Successfully merging this pull request may close these issues.

3 participants