Skip to content

MSI: Add support for INSTALLER_UNATTENDED#1276

Merged
lrandersson merged 5 commits into
conda:mainfrom
lrandersson:dev-ra-844
Jul 8, 2026
Merged

MSI: Add support for INSTALLER_UNATTENDED#1276
lrandersson merged 5 commits into
conda:mainfrom
lrandersson:dev-ra-844

Conversation

@lrandersson

@lrandersson lrandersson commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Description

Add support for the environment variable INSTALLER_UNATTENDED for MSI installers (this is fixed upstream beeware/briefcase-windows-app-template#94).

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@lrandersson lrandersson self-assigned this Jun 30, 2026
@github-project-automation github-project-automation Bot moved this to 🆕 New in 🔎 Review Jun 30, 2026
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jun 30, 2026
@lrandersson lrandersson marked this pull request as ready for review June 30, 2026 16:32
@lrandersson lrandersson requested a review from a team as a code owner June 30, 2026 16:32

@marcoesters marcoesters left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a briefcase feature, do we need to increase/set the lower bound for the briefcase version in the dependency list?

@lrandersson lrandersson force-pushed the dev-ra-844 branch 2 times, most recently from bf84f83 to 17f3c7f Compare July 7, 2026 16:51
@lrandersson lrandersson requested a review from marcoesters July 8, 2026 12:57

@marcoesters marcoesters left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a test to one of the examples to assert that this variable is actually set?

@lrandersson

Copy link
Copy Markdown
Contributor Author

Could we add a test to one of the examples to assert that this variable is actually set?

See d0bea71

@github-project-automation github-project-automation Bot moved this from 🆕 New to ✅ Approved in 🔎 Review Jul 8, 2026
@lrandersson lrandersson merged commit f4967e8 into conda:main Jul 8, 2026
35 of 36 checks passed
@github-project-automation github-project-automation Bot moved this from ✅ Approved to 🏁 Done in 🔎 Review Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed [bot] added once the contributor has signed the CLA

Projects

Status: 🏁 Done

Development

Successfully merging this pull request may close these issues.

3 participants