Fix installer option inconsistency between EXE/MSI#1277
Merged
Conversation
conda-bot
added
the
cla-signed
lrandersson
commented
Jun 30, 2026
marcoesters
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed during local testing that two of the installer options default values were hardcoded
Falseinstead of using the same approach as the EXE installers. This PR fixes that and updates a test to account for this (since these were defaultFalsethe test example pre/post uninstall/install scripts were never run by the MSI installer).I also did another check to see if any other option was inconsistently set but these two were the only ones I found.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?