Scheduler update by v1r3n · Pull Request #896 · conductor-oss/conductor

v1r3n · 2026-03-19T14:48:17Z

Pull Request type

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Changes in this PR

Scheduler event field injection

When a workflow is triggered by the scheduler, the workflow's event field is now set to scheduler:. This makes it easy to identify which schedule fired a given workflow execution — visible in
workflow history, the UI, and any downstream observability tooling that reads the event field.

Implementation: added event to StartWorkflowRequest, wired it through the StartWorkflowInput constructor (which already had the field but never populated it from a request), and set it in

SchedulerService.dispatchWorkflow before calling startWorkflow. Test added to AbstractSchedulerServiceIntegrationTest so all persistence backends (Postgres, MySQL, SQLite, Redis) inherit the assertion.

Scheduler examples and scripts

Added scheduler/examples/ with 8 verified workflow + schedule JSON pairs covering common patterns: basic every-minute, catchup mode, bounded schedule, multi-step FORK/JOIN, failure scenario, concurrent
execution, input parameterization, and DO_WHILE internal loop. Includes seed.sh for the Docker demo stack and a README quickstart covering the full API lifecycle, cron format, configuration reference, and
per-scenario run instructions.

Added scheduler/scripts/ with 4 concurrency/load test scripts used during live validation (concurrent UPSERT, concurrent resume, thundering-herd N-schedule fanout, multi-client load blast).

server-lite scheduler wiring

Added conductor-scheduler-sqlite-persistence to server-lite/build.gradle and enabled conductor.scheduler.enabled=true in its application.properties so the standalone lite server supports the scheduler out of
the box.

Issue #

Covers SQLite module, Redis module (via JedisProxy), and replacement of all mock-based service tests with Testcontainers-backed integration tests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Fix @ConditionalOnExpression default: scheduler.enabled:false (not true) - Add JedisProxy extension requirements (zscore, zrevrangeByScore) - Document truncateStore() hook for Redis test teardown (no DataSource) - Replace batch hmget/mget with individual hget/get loop (JedisProxy gap) - Fix removeExecutionRecord to ZREM exec_by_sched via read-first pattern - Add Redis build.gradle dependencies and settings.gradle registration - Add META-INF/spring/AutoConfiguration.imports to both new modules - Add smoke test subclasses to all four modules in the concrete class table - Clarify @ClassRule Redis container lifecycle for JUnit 4 - Note secondary index omission is intentional for SQLite dev/test scope Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Change SQLite db.type from 'memory' to 'sqlite' (established codebase value) - Clarify truncateStore() refactoring as explicit prerequisite task, not already done — prevents implementer confusion with current base classes - Mark DST/catchup scenarios as future work (not yet in testFixtures) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

@configuration

Covers 21 tasks across 4 chunks: prerequisite test-base refactoring, SQLite module, Redis module (JedisProxy extensions + DAO), and mock test deletion. All review findings applied: - @TestConfiguration instead of @configuration in SQLite tests - FlywayAutoConfiguration added to @ContextConfiguration - SqliteSchedulerAutoConfigurationSmokeTest unconditionally overrides baseRunner() to add hikari.maximum-pool-size=1 - zrevrangeByScore wraps Set<String> in new ArrayList<>() for List return - deleteWorkflowSchedule does HDEL schedules first to bound inconsistency - setNextRunTimeInEpoch guards with hexists for non-existent schedules - JedisProxy construction uses new JedisStandalone(jedisPool) correctly - Task 20 pre-deletion gate covers all 4 backends (not just 2) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…-JDBC test backends Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…chema and tests Implements a SQLite-backed SchedulerDAO using INSERT OR REPLACE for upserts, manual IN-placeholder expansion, and a single HikariCP connection (maximumPoolSize=1) to ensure in-memory database isolation. Includes Flyway migration, Spring Boot auto-configuration, DAO test, service integration test, and smoke test. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

… Redis DAO Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…y-backed DAO and tests Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

… backend integration tests Also add V2 Flyway migrations for MySQL and Postgres (execution_time column + index), fixing MySQL-incompatible IF NOT EXISTS syntax in ADD COLUMN / CREATE INDEX. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Add scheduler/examples/ with 8 verified workflow+schedule JSON pairs (basic, catchup, bounded, multistep fork/join, failure, concurrent, input-param, do-while) plus seed.sh and a full quickstart README - Add scheduler/scripts/ with 4 concurrency/load test scripts (concurrent write, concurrent resume, thundering herd, load blast) - Set workflow event field to "scheduler:<name>" on every scheduler- triggered workflow via StartWorkflowRequest.event, wired through StartWorkflowInput and WorkflowExecutorOps; test added to AbstractSchedulerServiceIntegrationTest - Wire conductor-scheduler-sqlite-persistence into server-lite and enable conductor.scheduler.enabled=true so the lite server supports the scheduler out of the box Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Add getAllExecutionRecords(limit) to SchedulerDAO interface and all 4 backends (Postgres, MySQL, SQLite, Redis) - Add searchExecutions() to SchedulerService with in-memory filtering by scheduleName, status, workflowType, startTime range, executionId, and free-text; supports sort and pagination - Add GET /api/scheduler/search/executions endpoint to SchedulerResource returning {results, totalHits} shape expected by the UI - Add Scheduler nav entries (Definitions, Executions) to UI sidebar - Point ui-next dev server at port 7001 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…endpoint Spring requires explicit parameter names when -parameters compiler flag is absent. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Add GET /schedules/search with pagination, freeText, paused, workflowName and sort filters — needed by /scheduleDef UI page - Change pause/resume from PUT to GET (matches Orkes contract and UI fetch) - Add GET /nextFewSchedules with cronExpression/startTime/endTime/limit params - Change POST /schedules to return 200 (void) to match Orkes - Change DELETE /schedules/{name} to return 200 to match Orkes - searchExecutions now returns SearchResult<WorkflowScheduleExecution> instead of raw Map - Add searchSchedules() and getListOfNextSchedules() to SchedulerService Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…tests across all backends - Add 73 integration tests to AbstractSchedulerServiceIntegrationTest covering: - searchSchedules: filter by workflowName, freeText, scheduleName, paused; sort by name/createTime/updatedTime ASC/DESC; pagination; combined filters - searchExecutions: all 6 query clause types (scheduleName IN, status IN, workflowType IN, startTime>/startTime<, executionId); freeText on scheduleName/workflowId/executionId; all sort fields (startTime, scheduledTime) with direction defaulting; pagination - getListOfNextSchedules: basic, startTime, endTime, and zero-limit cases - Fix RedisSchedulerDAO.getAllExecutionRecords to use a dedicated KEY_EXEC_SCHED_NAMES set instead of relying on getAllSchedules(), so executions saved without a schedule entry are correctly enumerated Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

+    }
+
+    private boolean matchesQuery(WorkflowScheduleExecution r, String query) {
+        for (String clause : query.split("(?i)\\s+AND\\s+")) {


+            }
+            Matcher m;
+
+            m = Pattern.compile("(?i)scheduleName\\s+IN\\s+\\(([^)]+)\\)").matcher(clause);


+                continue;
+            }
+
+            m = Pattern.compile("(?i)status\\s+IN\\s+\\(([^)]+)\\)").matcher(clause);


+                continue;
+            }
+
+            m = Pattern.compile("(?i)workflowType\\s+IN\\s+\\(([^)]+)\\)").matcher(clause);


manan164 · 2026-04-14T15:34:53Z


-    @PutMapping("/schedules/{name}/pause")
-    @ResponseStatus(HttpStatus.NO_CONTENT)
+    @GetMapping("/schedules/{name}/pause")


Should be PutMapping

manan164 · 2026-04-14T15:34:58Z


-    @PutMapping("/schedules/{name}/resume")
-    @ResponseStatus(HttpStatus.NO_CONTENT)
+    @GetMapping("/schedules/{name}/resume")


Should be PutMapping

manan164 · 2026-04-14T15:39:00Z

-            schedulerService.pauseSchedule(name);
-        }
+    public void pauseSchedule(@PathVariable("name") String name) {
+        schedulerService.pauseSchedule(name);


Lets add reason parameter back

manan164 · 2026-04-14T15:41:29Z

 import org.springframework.ai.openai.api.OpenAiAudioApi;
 import org.springframework.ai.openaisdk.OpenAiSdkChatModel;
 import org.springframework.ai.openaisdk.OpenAiSdkChatOptions;
+import org.springframework.ai.openaisdk.OpenAiSdkEmbeddingModel;


Unrelated changes

v1r3n and others added 14 commits March 19, 2026 00:51

docs: add scheduler DAO expansion design spec

e1e9ef2

Covers SQLite module, Redis module (via JedisProxy), and replacement of all mock-based service tests with Testcontainers-backed integration tests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Merge branch 'main' of github.com:conductor-oss/conductor

1f92bdb

refactor: add truncateStore() hook and protected baseRunner() for non…

4f59436

…-JDBC test backends Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat: add zscore() and zrevrangeByScore() to JedisProxy for scheduler…

a83fc51

… Redis DAO Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat: add conductor-scheduler-redis-persistence module with JedisProx…

36a29bc

…y-backed DAO and tests Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix: remove unused DataSource import from Redis scheduler tests

ec850b6

fix: restore required DataSource import in Redis scheduler tests

69a208b

updates to scheduler

780b8d3

v1r3n requested a review from nthmost-orkes March 19, 2026 14:48

v1r3n and others added 7 commits March 19, 2026 08:01

fix: add explicit @RequestParam value attributes to searchExecutions …

7ce0c46

…endpoint Spring requires explicit parameter names when -parameters compiler flag is absent. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

style: apply spotless formatting

4fca052

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Update .gitignore

db1bdc3

tests

57e1f7c

github-advanced-security AI found potential problems Mar 19, 2026

View reviewed changes

v1r3n added 4 commits March 19, 2026 09:13

make it pretty

cacac0c

DAO updates

d0270a1

Update SchedulerResource.java

919bbc9

documentation and formatting fixes

6ae22e1

manan164 reviewed Apr 14, 2026

View reviewed changes

manan164 approved these changes Apr 14, 2026

View reviewed changes

v1r3n closed this May 2, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Scheduler update#896

Scheduler update#896
v1r3n wants to merge 25 commits into
mainfrom
scheduler_update

v1r3n commented Mar 19, 2026

Uh oh!

Check failure

Check failure

Check failure

Check failure

manan164 Apr 14, 2026

Uh oh!

manan164 Apr 14, 2026

Uh oh!

manan164 Apr 14, 2026

Uh oh!

manan164 Apr 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

v1r3n commented Mar 19, 2026

Pull Request type

Changes in this PR

Scheduler event field injection

Implementation: added event to StartWorkflowRequest, wired it through the StartWorkflowInput constructor (which already had the field but never populated it from a request), and set it in

Scheduler examples and scripts

Added scheduler/scripts/ with 4 concurrency/load test scripts used during live validation (concurrent UPSERT, concurrent resume, thundering-herd N-schedule fanout, multi-client load blast).

server-lite scheduler wiring

Uh oh!

Check failure

Uh oh!

Uh oh!

Check failure

Uh oh!

Uh oh!

Check failure

Uh oh!

Uh oh!

Check failure

Uh oh!

Uh oh!

manan164 Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

manan164 Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

manan164 Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

manan164 Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants