docs: fix while True busy-wait and cURL sync endpoint in quickstart#955
Closed
nthmost-orkes wants to merge 3 commits into
Closed
docs: fix while True busy-wait and cURL sync endpoint in quickstart#955nthmost-orkes wants to merge 3 commits into
nthmost-orkes wants to merge 3 commits into
Conversation
v1r3n
reviewed
Apr 2, 2026
| |-----|------| | ||
| | `conductor workflow create workflow.json` | `curl -X POST http://localhost:8080/api/metadata/workflow -H 'Content-Type: application/json' -d @workflow.json` | | ||
| | `conductor workflow start -w hello_workflow --sync` | `curl -s -X POST http://localhost:8080/api/workflow/hello_workflow -H 'Content-Type: application/json'` | | ||
| | `conductor workflow start -w hello_workflow --sync` | `curl -s -X POST "http://localhost:8080/api/workflow/execute/hello_workflow/1" -H 'Content-Type: application/json' -d '{}'` | |
Collaborator
There was a problem hiding this comment.
the previous URL is correct. please revert back.
Contributor
Author
There was a problem hiding this comment.
yeah i had noticed that, not sure why it was changed, then of course was paying attention to other things. will revisit this a little later -- i want to understand why Claude thought to change this
Contributor
Author
There was a problem hiding this comment.
Reverted — you're right, doesn't exist in OSS Conductor. The original POST /api/workflow/{name} is the correct cURL equivalent; --sync is purely CLI-side wait behavior. Fixed in the latest commit.
The /api/workflow/execute endpoint does not exist in OSS Conductor.
The original POST /api/workflow/{name} is the correct cURL equivalent
(async start; --sync is a CLI-side wait, not a server feature).
Contributor
Author
|
Closing as superseded by #930 (merged). Both issues this PR targeted are already fixed in main:
Nothing to salvage here — the branch history is tangled and both issues are resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes conductor-oss/getting-started#13, conductor-oss/getting-started#14
Changes
#13 —
while True: passbusy-waitReplaces the CPU-spinning
while True: passkeep-alive loop withtime.sleep(1), which yields the CPU between polls. Thetimemodule is already in stdlib so no new dependency is introduced.#14 — cURL sync equivalent is wrong
The
--syncflag uses Conductor's synchronous execution endpoint (/api/workflow/execute/{name}/{version}), not the async start endpoint. The cURL equivalent in the Docker table now uses the correct endpoint and includes a request body (-d '{}').