Merge pull request #70 from conductor-oss/feature/signal-sync-timeout

Timeout param and response in signal sync

Author: mp-orkes

orkes-client/src/main/java/io/orkes/conductor/client/http/OrkesTaskClient.java

@@ -154,17 +154,40 @@ public SignalResponse signal(String workflowId, Task.Status status, Map<String,
      * @return SignalResponse with data based on the return strategy
      */
     public SignalResponse signal(String workflowId, Task.Status status, Map<String, Object> output, ReturnStrategy returnStrategy) {
-        ConductorClientRequest request = ConductorClientRequest.builder()
+        return signal(workflowId, status, output, returnStrategy, null);
+    }
+
+    /**
+     * Signals a task in a workflow synchronously and returns data based on the specified return strategy.
+     *
+     * @param workflowId     Workflow Id of the workflow to be signaled
+     * @param status         Signal status to be set for the workflow
+     * @param output         Output for the task
+     * @param returnStrategy Strategy for what data to return
+     * @param timeoutMillis  Timeout in milliseconds
+     * @return SignalResponse with data based on the return strategy
+     */
+    public SignalResponse signal(String workflowId,
+                                 Task.Status status,
+                                 Map<String, Object> output,
+                                 ReturnStrategy returnStrategy,
+                                 Long timeoutMillis) {
+        var builder = ConductorClientRequest.builder()
                 .method(ConductorClientRequest.Method.POST)
                 .path("/tasks/{workflowId}/{status}/signal/sync")
                 .addPathParam("workflowId", workflowId)
                 .addPathParam("status", status.name())
                 .addQueryParam("returnStrategy", returnStrategy.name())
-                .body(output)
-                .build();
+                .body(output);
+
+        if (timeoutMillis != null) {
+            builder.addQueryParam("timeoutMillis", timeoutMillis.toString());
+        }
 
-        ConductorClientResponse<SignalResponse> resp = client.execute(request, new TypeReference<SignalResponse>() {
+        var request = builder.build();
+        var resp = client.execute(request, new TypeReference<SignalResponse>() {
         });
+
         return resp.getData();
     }
 

orkes-client/src/main/java/io/orkes/conductor/client/model/SignalResponse.java

@@ -39,6 +39,7 @@ public class SignalResponse {
     private Map<String, Object> output;
     private Integer priority;
     private Map<String, Object> variables;
+    private boolean signalTimeout;
 
     // Fields specific to TARGET_WORKFLOW & BLOCKING_WORKFLOW
     private List<Task> tasks;