Skip to content

Standardized metrics export - feature flagged#114

Open
chrishagglund-ship-it wants to merge 30 commits into
mainfrom
gated-metrics-standardization
Open

Standardized metrics export - feature flagged#114
chrishagglund-ship-it wants to merge 30 commits into
mainfrom
gated-metrics-standardization

Conversation

@chrishagglund-ship-it
Copy link
Copy Markdown
Contributor

@chrishagglund-ship-it chrishagglund-ship-it commented May 4, 2026

Provides cross-sdk standardized metrics output format, enabled by setting WORKER_CANONICAL_METRICS=true, see standardized metrics catalog for the proposed standard metrics catalog

The motivation for this is to enable a consistent metrics output surface across all the conductor SDKs

@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

❌ Patch coverage is 71.72061% with 166 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...netflix/conductor/client/automator/TaskRunner.java 32.55% 26 Missing and 3 partials ⚠️
.../com/netflix/conductor/client/http/TaskClient.java 13.33% 24 Missing and 2 partials ⚠️
...netflix/conductor/client/http/ConductorClient.java 61.53% 16 Missing and 4 partials ⚠️
...nductor/client/automator/TaskRunnerConfigurer.java 24.00% 12 Missing and 7 partials ⚠️
...prometheus/AbstractPrometheusMetricsCollector.java 57.50% 15 Missing and 2 partials ⚠️
...uctor/client/metrics/prometheus/MetricsBundle.java 0.00% 11 Missing ⚠️
...ent/events/listeners/TaskRunnerEventsListener.java 0.00% 8 Missing ⚠️
...lix/conductor/client/metrics/MetricsCollector.java 0.00% 7 Missing ⚠️
.../netflix/conductor/client/http/WorkflowClient.java 33.33% 4 Missing and 2 partials ⚠️
...metrics/prometheus/PrometheusApiClientMetrics.java 91.48% 2 Missing and 2 partials ⚠️
... and 13 more
Files with missing lines Coverage Δ Complexity Δ
...rometheus/CanonicalPrometheusMetricsCollector.java 100.00% <100.00%> (ø) 27.00 <27.00> (?)
...s/prometheus/LegacyPrometheusMetricsCollector.java 100.00% <100.00%> (ø) 23.00 <23.00> (?)
...ctor/client/events/listeners/ListenerRegister.java 97.77% <100.00%> (+4.44%) 6.00 <6.00> (+3.00)
.../conductor/client/http/ConductorClientRequest.java 71.21% <100.00%> (+1.85%) 9.00 <1.00> (+1.00)
...nt/metrics/prometheus/MetricsCollectorFactory.java 91.66% <91.66%> (ø) 6.00 <6.00> (?)
...metrics/prometheus/PrometheusMetricsCollector.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...client/events/taskrunner/ActiveWorkersChanged.java 80.00% <80.00%> (ø) 2.00 <2.00> (?)
...nductor/client/events/taskrunner/TaskAckError.java 85.71% <85.71%> (ø) 3.00 <3.00> (?)
...uctor/client/events/taskrunner/TaskAckFailure.java 80.00% <80.00%> (ø) 2.00 <2.00> (?)
...ient/events/taskrunner/TaskExecutionQueueFull.java 66.66% <66.66%> (ø) 1.00 <1.00> (?)
... and 17 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chrishagglund-ship-it chrishagglund-ship-it marked this pull request as draft May 7, 2026 19:11
@chrishagglund-ship-it chrishagglund-ship-it force-pushed the gated-metrics-standardization branch from 59f85d4 to 420bb4c Compare May 10, 2026 17:08
@chrishagglund-ship-it chrishagglund-ship-it marked this pull request as ready for review May 11, 2026 15:50
…conductor instance that it downloads. gitignore those sqlite files (todo: clean them up after the test)
…d docs to remove link to non public metrics harmonization doc, restoring original behavior around isEnforceThresholds
… made changelog entry much more concise for human consumption
@chrishagglund-ship-it chrishagglund-ship-it force-pushed the gated-metrics-standardization branch from 72239f4 to 096dfca Compare May 20, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant