Skip to content

Commit 1c82c1f

Browse files
simplify gh action, add name
1 parent 1b82930 commit 1c82c1f

1 file changed

Lines changed: 13 additions & 15 deletions

File tree

.github/workflows/pull_request.yml

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -23,30 +23,28 @@ jobs:
2323
fail-fast: false
2424
matrix:
2525
node-version: [18, 20, 22]
26-
test:
27-
- name: "unit"
28-
- name: "integration:v5"
29-
- name: "integration:v4"
26+
test: ["unit", "integration:v5", "integration:v4"]
27+
name: Node.js v${{ matrix.node-version }} - ${{ matrix.test }}
3028
steps:
3129
- name: Checkout
3230
uses: actions/checkout@v4
3331
- name: Set up Node
3432
uses: actions/setup-node@v4
3533
with:
36-
node-version: ${{matrix.node-version}}
34+
node-version: ${{ matrix.node-version }}
3735
- name: Install Dependencies
3836
run: npm ci
39-
- name: Run ${{matrix.test.name}} Tests and Add Annotations
40-
run: npm run test:${{matrix.test.name}} -- --ci --reporters=default --reporters=github-actions --reporters=jest-junit
37+
- name: Run ${{ matrix.test }} Tests and Add Annotations
38+
run: npm run test:${{ matrix.test }} -- --ci --reporters=default --reporters=github-actions --reporters=jest-junit
4139
env:
42-
CONDUCTOR_SERVER_URL: ${{matrix.test.name == 'integration:v4' && vars.SERVER_URL_V4 || vars.SERVER_URL}}
43-
CONDUCTOR_AUTH_KEY: ${{matrix.test.name == 'integration:v4' && secrets.AUTH_KEY_V4 || secrets.AUTH_KEY}}
44-
CONDUCTOR_AUTH_SECRET: ${{matrix.test.name == 'integration:v4' && secrets.AUTH_SECRET_V4 || secrets.AUTH_SECRET}}
45-
JEST_JUNIT_OUTPUT_NAME: ${{matrix.test.name}}-test-results.xml
46-
- name: Publish ${{matrix.test.name}} Test Results
40+
CONDUCTOR_SERVER_URL: ${{ matrix.test == 'integration:v4' && vars.SERVER_URL_V4 || vars.SERVER_URL }}
41+
CONDUCTOR_AUTH_KEY: ${{ matrix.test == 'integration:v4' && secrets.AUTH_KEY_V4 || secrets.AUTH_KEY }}
42+
CONDUCTOR_AUTH_SECRET: ${{ matrix.test == 'integration:v4' && secrets.AUTH_SECRET_V4 || secrets.AUTH_SECRET }}
43+
JEST_JUNIT_OUTPUT_NAME: ${{ matrix.test }}-test-results.xml
44+
- name: Publish ${{ matrix.test }} Test Results
4745
uses: dorny/test-reporter@v2
48-
if: ${{!cancelled()}}
46+
if: ${{ !cancelled() }}
4947
with:
50-
name: ${{matrix.test.name}} Test Report
51-
path: reports/${{matrix.test.name}}-test-results.xml
48+
name: ${{ matrix.test }} Test Report
49+
path: reports/${{ matrix.test }}-test-results.xml
5250
reporter: jest-junit

0 commit comments

Comments
 (0)