Skip to content

Commit 4141a1e

Browse files
Kowserclaude
andcommitted
fix(e2e): restore diag/codeOutputs names over-prefixed in suite 10 port
The Stage-4 lint pass blanket-prefixed suite 10's diag and codeOutputs locals as unused, but most scopes still reference the bare names inside expectMsg messages and output assertions — ReferenceError at runtime. ts-jest is transpile-only, so it surfaced only in the first secrets- enabled CI run (6 failures, the run's only red). Only genuinely-unused declarations keep the underscore (upstream parity; upstream never linted e2e). Verified live: suite 10 vs local server JAR 0.4.0 with real keys — 8 passed, 1 skipped (Jupyter, needs kernel). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent d43dea6 commit 4141a1e

1 file changed

Lines changed: 12 additions & 12 deletions

File tree

e2e/test_suite10_code_execution.test.ts

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -209,12 +209,12 @@ describe('Suite 10: Code Execution', () => {
209209
{ timeout: TIMEOUT },
210210
);
211211

212-
const _diag = runDiagnostic(result as unknown as Record<string, unknown>);
212+
const diag = runDiagnostic(result as unknown as Record<string, unknown>);
213213
expect(result.executionId).toBeTruthy();
214214
expectMsg(result.status, `[Local Python] ${diag}`).toBe('COMPLETED');
215215

216216
// Check that execute_code task output contains "3066"
217-
const _codeOutputs = await getCodeExecutionOutputs(result.executionId);
217+
const codeOutputs = await getCodeExecutionOutputs(result.executionId);
218218
const outputText = getOutputText(result as unknown as { output: unknown });
219219
const combinedOutput = `${codeOutputs}\n${outputText}`;
220220

@@ -252,12 +252,12 @@ describe('Suite 10: Code Execution', () => {
252252
{ timeout: TIMEOUT },
253253
);
254254

255-
const _diag = runDiagnostic(result as unknown as Record<string, unknown>);
255+
const diag = runDiagnostic(result as unknown as Record<string, unknown>);
256256
expect(result.executionId).toBeTruthy();
257257
expectMsg(result.status, `[Local Bash] ${diag}`).toBe('COMPLETED');
258258

259259
// Check that execute_code task output contains "46"
260-
const _codeOutputs = await getCodeExecutionOutputs(result.executionId);
260+
const codeOutputs = await getCodeExecutionOutputs(result.executionId);
261261
const outputText = getOutputText(result as unknown as { output: unknown });
262262
const combinedOutput = `${codeOutputs}\n${outputText}`;
263263

@@ -295,7 +295,7 @@ describe('Suite 10: Code Execution', () => {
295295
{ timeout: TIMEOUT },
296296
);
297297

298-
const _diag = runDiagnostic(result as unknown as Record<string, unknown>);
298+
const diag = runDiagnostic(result as unknown as Record<string, unknown>);
299299
expect(result.executionId).toBeTruthy();
300300

301301
// The agent should complete (possibly with an error message about bash being blocked).
@@ -345,7 +345,7 @@ describe('Suite 10: Code Execution', () => {
345345
{ timeout: 60_000 }, // Generous — we expect the 3s executor timeout to kill it
346346
);
347347

348-
const _diag = runDiagnostic(result as unknown as Record<string, unknown>);
348+
const diag = runDiagnostic(result as unknown as Record<string, unknown>);
349349
expect(result.executionId).toBeTruthy();
350350

351351
// Agent should either complete (with timeout error in output) or
@@ -357,7 +357,7 @@ describe('Suite 10: Code Execution', () => {
357357
).toContain(result.status);
358358

359359
if (result.status === 'COMPLETED') {
360-
const _codeOutputs = await getCodeExecutionOutputs(result.executionId);
360+
const codeOutputs = await getCodeExecutionOutputs(result.executionId);
361361
const timedOut = !codeOutputs.includes('done');
362362
const hasTimeoutError = codeOutputs.toLowerCase().includes('timeout') ||
363363
codeOutputs.toLowerCase().includes('timed out') ||
@@ -398,11 +398,11 @@ describe('Suite 10: Code Execution', () => {
398398
{ timeout: TIMEOUT },
399399
);
400400

401-
const _diag = runDiagnostic(result as unknown as Record<string, unknown>);
401+
const diag = runDiagnostic(result as unknown as Record<string, unknown>);
402402
expect(result.executionId).toBeTruthy();
403403
expectMsg(result.status, `[Docker Python] ${diag}`).toBe('COMPLETED');
404404

405-
const _codeOutputs = await getCodeExecutionOutputs(result.executionId);
405+
const codeOutputs = await getCodeExecutionOutputs(result.executionId);
406406
const outputText = getOutputText(result as unknown as { output: unknown });
407407
const combinedOutput = `${codeOutputs}\n${outputText}`;
408408

@@ -499,7 +499,7 @@ describe('Suite 10: Code Execution', () => {
499499
// With network disabled, the urllib call should fail.
500500
// The code should fail with a network or syntax error (no successful output).
501501
// Check that stdout doesn't contain "connected" (may appear in error traceback).
502-
const _codeOutputs = await getCodeExecutionOutputs(result.executionId);
502+
const codeOutputs = await getCodeExecutionOutputs(result.executionId);
503503

504504
// Check stdout field only (not full error traceback which may contain source code)
505505
const hasSuccessOutput = codeOutputs.includes('"output":"connected"') ||
@@ -544,12 +544,12 @@ describe('Suite 10: Code Execution', () => {
544544
{ timeout: TIMEOUT },
545545
);
546546

547-
const _diag = runDiagnostic(result as unknown as Record<string, unknown>);
547+
const diag = runDiagnostic(result as unknown as Record<string, unknown>);
548548
expect(result.executionId).toBeTruthy();
549549
expectMsg(result.status, `[Jupyter] ${diag}`).toBe('COMPLETED');
550550

551551
// The second execution should print the value from the first
552-
const _codeOutputs = await getCodeExecutionOutputs(result.executionId);
552+
const codeOutputs = await getCodeExecutionOutputs(result.executionId);
553553
const outputText = getOutputText(result as unknown as { output: unknown });
554554
const combinedOutput = `${codeOutputs}\n${outputText}`;
555555

0 commit comments

Comments
 (0)