fix lint

Author: v1r3n

AGENTS.md

@@ -61,12 +61,19 @@ npm run test:integration:orkes-v5
 
 After every code change, you **must** run the following before considering the work complete:
 
-1. **Unit tests** — all must pass:
+1. **Lint** — fix all lint errors in files you changed:
+   ```bash
+   npm run lint                          # Check all files
+   npx eslint --fix src/path/to/file.ts  # Auto-fix a specific file
+   ```
+   You must fix all lint errors in files you modified. Do not introduce new lint violations.
+
+2. **Unit tests** — all must pass:
    ```bash
    npm test
    ```
 
-2. **All examples** — each must complete successfully (requires a running Conductor server and `.env` credentials):
+3. **All examples** — each must complete successfully (requires a running Conductor server and `.env` credentials):
    ```bash
    export $(cat .env | xargs)
    npx ts-node -P tsconfig.json --transpile-only examples/helloworld.ts

src/sdk/clients/worker/TaskRunner.ts

@@ -299,14 +299,17 @@ export class TaskRunner {
    */
   private executeOneTask = async (task: Task): Promise<Task | undefined> => {
     const { workerID } = this.options;
+    // Safe: caller (executeTask) already validated these via isValidTask()
+    const taskId = task.taskId as string;
+    const workflowInstanceId = task.workflowInstanceId as string;
     const startTime = Date.now();
 
     // Publish TaskExecutionStarted event
     await this.eventDispatcher.publishTaskExecutionStarted({
       taskType: this.worker.taskDefName,
-      taskId: task.taskId!,
+      taskId,
       workerId: workerID,
-      workflowInstanceId: task.workflowInstanceId,
+      workflowInstanceId,
       timestamp: new Date(),
     });
 
@@ -326,8 +329,8 @@ export class TaskRunner {
       if (isTaskInProgress(result)) {
         const contextLogs = context.getLogs();
         const nextTask = await this.updateTaskWithRetry(task, {
-          workflowInstanceId: task.workflowInstanceId,
-          taskId: task.taskId,
+          workflowInstanceId,
+          taskId,
           status: "IN_PROGRESS",
           callbackAfterSeconds: result.callbackAfterSeconds,
           outputData:
@@ -338,15 +341,15 @@ export class TaskRunner {
         // Publish completion event for IN_PROGRESS
         await this.eventDispatcher.publishTaskExecutionCompleted({
           taskType: this.worker.taskDefName,
-          taskId: task.taskId!,
+          taskId,
           workerId: workerID,
-          workflowInstanceId: task.workflowInstanceId,
+          workflowInstanceId,
           durationMs,
           timestamp: new Date(),
         });
 
         this.logger.debug(
-          `Task ${task.taskId} returned IN_PROGRESS, callback after ${result.callbackAfterSeconds}s`
+          `Task ${taskId} returned IN_PROGRESS, callback after ${result.callbackAfterSeconds}s`
         );
         return nextTask;
       }
@@ -383,20 +386,20 @@ export class TaskRunner {
       // Publish TaskExecutionCompleted event
       await this.eventDispatcher.publishTaskExecutionCompleted({
         taskType: this.worker.taskDefName,
-        taskId: task.taskId!,
+        taskId,
         workerId: workerID,
-        workflowInstanceId: task.workflowInstanceId,
+        workflowInstanceId,
         durationMs,
         outputSizeBytes,
         timestamp: new Date(),
       });
 
       const nextTask = await this.updateTaskWithRetry(task, {
         ...merged,
-        workflowInstanceId: task.workflowInstanceId,
-        taskId: task.taskId,
+        workflowInstanceId,
+        taskId,
       });
-      this.logger.debug(`Task has executed successfully ${task.taskId}`);
+      this.logger.debug(`Task has executed successfully ${taskId}`);
       return nextTask;
     } catch (error: unknown) {
       const durationMs = Date.now() - startTime;
@@ -405,9 +408,9 @@ export class TaskRunner {
       // Publish TaskExecutionFailure event
       await this.eventDispatcher.publishTaskExecutionFailure({
         taskType: this.worker.taskDefName,
-        taskId: task.taskId!,
+        taskId,
         workerId: workerID,
-        workflowInstanceId: task.workflowInstanceId,
+        workflowInstanceId,
         cause: err,
         durationMs,
         timestamp: new Date(),
@@ -419,7 +422,7 @@ export class TaskRunner {
 
       if (isNonRetryable) {
         this.logger.error(
-          `Task ${task.taskId} failed with terminal error (no retry): ${err.message}`
+          `Task ${taskId} failed with terminal error (no retry): ${err.message}`
         );
       }
 
@@ -428,21 +431,21 @@ export class TaskRunner {
         {
           log: `${err.name}: ${err.message}${err.stack ? "\n" + err.stack : ""}`,
           createdTime: Date.now(),
-          taskId: task.taskId,
+          taskId,
         },
       ];
 
       const nextTask = await this.updateTaskWithRetry(task, {
-        workflowInstanceId: task.workflowInstanceId,
-        taskId: task.taskId,
+        workflowInstanceId,
+        taskId,
         reasonForIncompletion:
           (error as Record<string, string>)?.message ?? DEFAULT_ERROR_MESSAGE,
         status,
         outputData: {},
         logs: errorLogs,
       });
       this.errorHandler(err, task);
-      this.logger.error(`Error executing ${task.taskId}`, error);
+      this.logger.error(`Error executing ${taskId}`, error);
 
       // Even on failure, chain to next task — the failure was for THIS task
       return nextTask;

src/sdk/worker/metrics/MetricsCollector.ts

@@ -383,12 +383,12 @@ export class MetricsCollector implements TaskRunnerEventsListener {
     const lines: string[] = [];
 
     // ── Labelled counters ──
-    const labelledCounters: Array<{
+    const labelledCounters: {
       name: string;
       help: string;
       data: Map<string, number>;
       labelName: string;
-    }> = [
+    }[] = [
       {
         name: `${p}_task_poll_total`,
         help: "Total number of task polls",
@@ -457,11 +457,11 @@ export class MetricsCollector implements TaskRunnerEventsListener {
     }
 
     // ── Global counters (no labels) ──
-    const globalCounters: Array<{
+    const globalCounters: {
       name: string;
       help: string;
       value: number;
-    }> = [
+    }[] = [
       {
         name: `${p}_thread_uncaught_exceptions_total`,
         help: "Total uncaught exceptions",
@@ -487,12 +487,12 @@ export class MetricsCollector implements TaskRunnerEventsListener {
     }
 
     // ── Summaries with quantiles ──
-    const summaries: Array<{
+    const summaries: {
       name: string;
       help: string;
       data: Map<string, number[]>;
       labelName: string;
-    }> = [
+    }[] = [
       {
         name: `${p}_task_poll_time`,
         help: "Task poll duration in milliseconds",