Commit e32a1cb
authored
Refactor project structure according to actual logical layers (#93)
This is not just a refactoring, but actually an enhancement in different areas of the project. With this changes we are seeing following improvements:
- The LLM has become capable of properly understanding the project, reading, and writing code. Previously, it often introduced errors by modifying OpenAPI‑generated code, which required additional iterations.
- The updated structure is simple and intuitive, especially for people more familiar to JavaScript projects.
- A similar approach is used in other popular libraries that rely on OpenAPI generators, where generated code is isolated from SDK abstractions. For example, AWS JS SDK v3 (https://github.com/aws/aws-sdk-js-v3) and the Kubernetes JavaScript Client (https://github.com/kubernetes-client/javascript).
The codebase itself remains unchanged for end users. The PR only includes file and folder renames, updated import/export statements, and moving types and helpers into separate files. It does not affect functionality, build process, or user‑facing behavior.
List of changes:
- All generated code now resides in src/open-api/generated, with manual rewrites, additions and export encapsulation control layered on top within src/open-api - a cohesive OpenAPI layer used as a single unit by the rest of the project.
- SDK abstractions formerly under orkes, core, task, and common have been moved into sdk/clients, sdk/createConductorClient, sdk/generators, and sdk/builders.
- The monolithic code was reorganized into helper modules and shared types located at appropriate levels based on reuse.
- Updated related import/export statements (no changes affecting user‑facing behavior).
- Test folder v5-only was removed and all tests were moved into their domain‑specific files without additional structural test separation. Related tests are now selected via environment variable, updated package.json test scripts according to this change.1 parent f0c6daa commit e32a1cb
153 files changed
Lines changed: 1931 additions & 1738 deletions
File tree
- .github/workflows
- integration-tests
- common
- v5-only
- src
- core
- integration-tests
- metadata
- utils
- open-api
- generated
- client
- core
- spec
- orkes
- sdk
- builders
- tasks
- __tests__
- clients
- application
- event
- human
- metadata
- scheduler
- service-registry
- task
- template
- worker
- __tests__
- workflow
- helpers
- createConductorClient
- helpers
- __tests__
- generators
- __tests__
- helpers
- task
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| |||
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
| 1 | + | |
| 2 | + | |
This file was deleted.
0 commit comments