adjust some help labels that were piggybacking on legacy for canonical

Author: chrishagglund-ship-it

src/conductor/client/telemetry/canonical_metrics_collector.py

@@ -170,7 +170,7 @@ def set_active_workers(self, task_type: str, count: int) -> None:
     def record_task_poll_time(self, task_type: str, time_spent: float, status: str = "SUCCESS") -> None:
         self._observe_histogram(
             name=MetricName.TASK_POLL_TIME_HISTOGRAM,
-            documentation=MetricDocumentation.TASK_POLL_TIME_HISTOGRAM,
+            documentation=MetricDocumentation.TASK_POLL_TIME_HISTOGRAM_CANONICAL,
             labels={MetricLabel.TASK_TYPE: task_type, MetricLabel.STATUS: status},
             value=time_spent,
             buckets=TIME_BUCKETS,
@@ -179,7 +179,7 @@ def record_task_poll_time(self, task_type: str, time_spent: float, status: str =
     def record_task_execute_time(self, task_type: str, time_spent: float, status: str = "SUCCESS") -> None:
         self._observe_histogram(
             name=MetricName.TASK_EXECUTE_TIME_HISTOGRAM,
-            documentation=MetricDocumentation.TASK_EXECUTE_TIME_HISTOGRAM,
+            documentation=MetricDocumentation.TASK_EXECUTE_TIME_HISTOGRAM_CANONICAL,
             labels={MetricLabel.TASK_TYPE: task_type, MetricLabel.STATUS: status},
             value=time_spent,
             buckets=TIME_BUCKETS,

src/conductor/client/telemetry/model/metric_documentation.py

@@ -17,14 +17,16 @@ class MetricDocumentation(str, Enum):
     TASK_POLL_TIME_HISTOGRAM = "Task poll duration in seconds with quantiles"
     TASK_RESULT_SIZE = "Records output payload size of a task"
     TASK_UPDATE_ERROR = "Task status cannot be updated back to server"
-    TASK_UPDATE_TIME_HISTOGRAM = "Task update duration in seconds with quantiles"
+    TASK_UPDATE_TIME_HISTOGRAM = "Latency of task result updates in seconds"
     THREAD_UNCAUGHT_EXCEPTION = "thread_uncaught_exceptions"
     WORKER_RESTART = "Worker subprocess restarted"
     WORKFLOW_START_ERROR = "Counter for workflow start errors"
     WORKFLOW_INPUT_SIZE = "Records input payload size of a workflow"
 
     # Canonical-only documentation strings
     API_REQUEST_TIME_CANONICAL = "Latency of HTTP API client requests in seconds"
+    TASK_POLL_TIME_HISTOGRAM_CANONICAL = "Latency of task poll requests in seconds"
+    TASK_EXECUTE_TIME_HISTOGRAM_CANONICAL = "Duration of worker task execution in seconds"
     TASK_EXECUTION_STARTED = "Incremented when a polled task is dispatched to the worker function"
     TASK_POLL_ERROR = "Incremented when a poll request fails client-side"
     TASK_RESULT_SIZE_BYTES = "Serialized byte size of task result output"