Skip to content

Commit 443e31d

Browse files
restore default version label in one legacy metric
1 parent 99c9457 commit 443e31d

1 file changed

Lines changed: 13 additions & 0 deletions

File tree

src/conductor/client/telemetry/legacy_metrics_collector.py

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
from conductor.client.configuration.settings.metrics_settings import MetricsSettings
1313
from conductor.client.telemetry import metrics_collector_base as _mcb
1414
from conductor.client.telemetry.metrics_collector_base import MetricsCollectorBase
15+
from conductor.client.event.workflow_events import WorkflowInputPayloadSize
1516
from conductor.client.telemetry.model.metric_documentation import MetricDocumentation
1617
from conductor.client.telemetry.model.metric_label import MetricLabel
1718
from conductor.client.telemetry.model.metric_name import MetricName
@@ -187,6 +188,18 @@ def record_api_request_time(self, method: str, uri: str, status: str, time_spent
187188
value=time_spent,
188189
)
189190

191+
# ------------------------------------------------------------------
192+
# Event handler overrides
193+
# ------------------------------------------------------------------
194+
195+
def on_workflow_input_payload_size(self, event: WorkflowInputPayloadSize) -> None:
196+
# The original metrics_collector.py defaulted version to "1" when
197+
# absent. The canonical standard across all SDKs is "" (empty
198+
# string). We preserve "1" here so that legacy upgraders don't see
199+
# a time-series label change.
200+
version_str = str(event.version) if event.version is not None else "1"
201+
self.record_workflow_input_payload_size(event.name, version_str, event.size_bytes)
202+
190203
# ------------------------------------------------------------------
191204
# Sizes (last-value gauges)
192205
# ------------------------------------------------------------------

0 commit comments

Comments
 (0)