Drop _legacy_scheduler_verbs dialect cache — stateless PUT-then-GET

pause/resume: try PUT; on 405 retry via GET. No per-instance memoization.
Contract test updated to pin the stateless behavior; docs adjusted.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: Kowser

CHANGELOG.md

@@ -30,4 +30,4 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - `@worker_task` workers are now picklable, making the decorator path work with the `spawn`/`forkserver` start methods (fixes `TypeError: cannot pickle '_thread.lock' object` and `PicklingError: it's not the same object as ...`; issues #264, #271): `Worker.api_client` is created lazily in the worker process, runtime state (locks, pending async tasks, background loop) is excluded from pickling and rebuilt in the child, and decorated functions are pickled as importable references resolved in the child
 - `TaskHandler.start_processes()` no longer hangs the interpreter when a worker fails to start (e.g., unpicklable state under `spawn`); it now cleans up already-started subprocesses and raises with actionable guidance
 - Worker processes killed by a signal now log a diagnostic hint (signal number, `PYTHONFAULTHANDLER=1` guidance) instead of restarting silently
-- Per-schedule pause/resume now work on both Conductor server families: the client sends `PUT` (the OSS Conductor dialect — the spec-generated `GET` failed there) and transparently falls back to `GET` on a 405 for Orkes servers, caching the working dialect per client instance
+- Per-schedule pause/resume now work on both Conductor server families: the client sends `PUT` (the OSS Conductor dialect — the spec-generated `GET` failed there) and transparently falls back to `GET` on a 405 for Orkes servers

docs/SCHEDULE.md

@@ -37,9 +37,9 @@ Operations for controlling schedule execution state.
 
 > **Verb compatibility:** OSS Conductor maps per-schedule pause/resume as `PUT`;
 > Orkes Conductor servers map them as `GET`. The client sends `PUT` first and
-> transparently falls back to `GET` on a 405, remembering the working dialect for
-> the rest of the client's lifetime — both server families work without configuration.
-> The optional `reason` parameter on `pause_schedule` is stored by OSS servers only.
+> transparently falls back to `GET` on a 405 — both server families work without
+> configuration. The optional `reason` parameter on `pause_schedule` is stored by
+> OSS servers only.
 
 ## Schedule Lifecycle Helpers
 

src/conductor/client/orkes/orkes_scheduler_client.py

@@ -15,10 +15,6 @@
 class OrkesSchedulerClient(OrkesBaseClient, SchedulerClient):
     def __init__(self, configuration: Configuration):
         super(OrkesSchedulerClient, self).__init__(configuration)
-        # Per-schedule pause/resume verbs differ by server family: OSS Conductor maps them
-        # PUT-only, Orkes Conductor GET-only. We send PUT first and remember a 405 so
-        # subsequent calls go straight to the legacy GET dialect.
-        self._legacy_scheduler_verbs = False
 
     def save_schedule(self, save_schedule_request: SaveScheduleRequest):
         self.schedulerResourceApi.save_schedule(save_schedule_request)
@@ -57,9 +53,8 @@ def delete_schedule(self, name: str):
         self.schedulerResourceApi.delete_schedule(name)
 
     def pause_schedule(self, name: str, reason: Optional[str] = None):
-        if self._legacy_scheduler_verbs:
-            self._pause_resume_via_get(name, "pause", reason)
-            return
+        # Per-schedule pause/resume verbs differ by server family: OSS Conductor maps
+        # them PUT-only, Orkes Conductor GET-only. Try PUT; on 405 retry via GET.
         try:
             if reason is None:
                 self.schedulerResourceApi.pause_schedule(name)
@@ -68,22 +63,17 @@ def pause_schedule(self, name: str, reason: Optional[str] = None):
         except ApiException as e:
             if e.status != 405:
                 raise
-            self._legacy_scheduler_verbs = True
             self._pause_resume_via_get(name, "pause", reason)
 
     def pause_all_schedules(self):
         self.schedulerResourceApi.pause_all_schedules()
 
     def resume_schedule(self, name: str):
-        if self._legacy_scheduler_verbs:
-            self._pause_resume_via_get(name, "resume")
-            return
         try:
             self.schedulerResourceApi.resume_schedule(name)
         except ApiException as e:
             if e.status != 405:
                 raise
-            self._legacy_scheduler_verbs = True
             self._pause_resume_via_get(name, "resume")
 
     def _pause_resume_via_get(self, name: str, action: str, reason: Optional[str] = None):

tests/unit/orkes/test_scheduler_resource_contract.py

@@ -124,18 +124,16 @@ def test_405_falls_back_to_get(self):
         assert args[2] == {"name": "sched-1"}
         assert ("reason", "maintenance") in args[3]
 
-    def test_405_result_is_cached_for_subsequent_calls(self):
+    def test_fallback_is_stateless(self):
         client = _client_with_mocks()
         client.schedulerResourceApi.pause_schedule.side_effect = ApiException(
             status=405, reason="Method Not Allowed"
         )
         client.pause_schedule("sched-1")
         client.pause_schedule("sched-2")
-        client.resume_schedule("sched-1")
-        # PUT attempted exactly once; everything after the 405 goes straight to GET.
-        assert client.schedulerResourceApi.pause_schedule.call_count == 1
-        client.schedulerResourceApi.resume_schedule.assert_not_called()
-        assert client.api_client.call_api.call_count == 3
+        # No dialect memoization: every call attempts PUT first, then falls back.
+        assert client.schedulerResourceApi.pause_schedule.call_count == 2
+        assert client.api_client.call_api.call_count == 2
 
     def test_404_propagates_without_fallback(self):
         client = _client_with_mocks()
@@ -145,7 +143,6 @@ def test_404_propagates_without_fallback(self):
         with pytest.raises(ApiException):
             client.pause_schedule("missing")
         client.api_client.call_api.assert_not_called()
-        assert client._legacy_scheduler_verbs is False
 
     def test_resume_405_falls_back_to_get(self):
         client = _client_with_mocks()