Skip to content

Commit b312836

Browse files
committed
Update test_metrics_collector_events.py
1 parent 3033e1e commit b312836

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

tests/unit/event/test_metrics_collector_events.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@ def test_on_poll_completed(self):
4545
)
4646
self.collector.on_poll_completed(event)
4747

48-
# Duration should be converted from ms to seconds
49-
mock_record.assert_called_once_with("test_task", 0.25)
48+
# Duration should be converted from ms to seconds, status added
49+
mock_record.assert_called_once_with("test_task", 0.25, status="SUCCESS")
5050

5151
def test_on_poll_failure(self):
5252
"""Test on_poll_failure event handler"""
@@ -87,8 +87,8 @@ def test_on_task_execution_completed(self):
8787
)
8888
self.collector.on_task_execution_completed(event)
8989

90-
# Duration should be converted from ms to seconds
91-
mock_time.assert_called_once_with("test_task", 0.5)
90+
# Duration should be converted from ms to seconds, status added
91+
mock_time.assert_called_once_with("test_task", 0.5, status="SUCCESS")
9292
mock_size.assert_called_once_with("test_task", 1024)
9393

9494
def test_on_task_execution_completed_no_output_size(self):
@@ -106,7 +106,7 @@ def test_on_task_execution_completed_no_output_size(self):
106106
)
107107
self.collector.on_task_execution_completed(event)
108108

109-
mock_time.assert_called_once_with("test_task", 0.5)
109+
mock_time.assert_called_once_with("test_task", 0.5, status="SUCCESS")
110110
# Should not record size if None
111111
mock_size.assert_not_called()
112112

0 commit comments

Comments
 (0)