Skip to content

Commit d23edc6

Browse files
author
Kowser
committed
ci(agent-e2e): drop agentspan server JAR, run against conductor-oss
conductor-oss ships the agent runtime by default from 3.32.0-rc.8, so the e2e server leg no longer needs the Agentspan release JAR. Server download switches to the conductor-oss boot jar (Maven Central); the Agentspan CLI binary stays on its own separate pin since test_suite16_cli_skills.py still drives it against this same server.
1 parent eee9fa6 commit d23edc6

2 files changed

Lines changed: 26 additions & 17 deletions

File tree

.github/workflows/agent-e2e.yml

Lines changed: 20 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11
name: Agent E2E
22

3-
# Runs the agent e2e suites (e2e/) against the released Agentspan
4-
# server JAR — a full Conductor server with the agent runtime baked in.
3+
# Runs the agent e2e suites (e2e/) against the Conductor OSS server boot
4+
# JAR (Maven Central) — the server this SDK ships against, with the agent
5+
# runtime on by default from 3.32.0-rc.8 onward. The Agentspan server JAR
6+
# is no longer used here; the Agentspan CLI binary is still downloaded
7+
# (its own separate pin) since e2e/test_suite16_cli_skills.py drives it
8+
# against this same server.
59
# tests/integration/ai stays manual-only (same as upstream Agentspan,
610
# which never ran its tests/integration in CI): run it locally against
711
# a live server with `pytest tests/integration/ai`.
@@ -12,12 +16,18 @@ name: Agent E2E
1216

1317
on: [pull_request, workflow_dispatch]
1418

19+
# least privilege: the token is only used to download the public agentspan
20+
# CLI release asset (gh release download) — read access suffices
21+
permissions:
22+
contents: read
23+
1524
concurrency:
1625
group: agent-e2e-${{ github.ref }}
1726
cancel-in-progress: true
1827

1928
env:
20-
AGENTSPAN_VERSION: "0.4.3" # pinned server/CLI release — bump deliberately
29+
CONDUCTOR_OSS_VERSION: "3.32.0-rc.8" # pinned server release — bump deliberately
30+
AGENTSPAN_CLI_VERSION: "0.4.3" # pinned CLI release — independent of the server
2131

2232
jobs:
2333
agent-e2e:
@@ -48,22 +58,20 @@ jobs:
4858
id: jar_cache
4959
uses: actions/cache@v4
5060
with:
51-
path: agentspan-server.jar
52-
key: agentspan-server-${{ env.AGENTSPAN_VERSION }}
61+
path: conductor-server.jar
62+
key: conductor-oss-server-${{ env.CONDUCTOR_OSS_VERSION }}
5363

54-
- name: Download server JAR from release
64+
- name: Download server JAR from Maven Central
5565
if: steps.jar_cache.outputs.cache-hit != 'true'
56-
env:
57-
GH_TOKEN: ${{ github.token }}
5866
run: |
59-
gh release download "v${AGENTSPAN_VERSION}" --repo agentspan-ai/agentspan \
60-
--pattern "agentspan-server-${AGENTSPAN_VERSION}.jar" --output agentspan-server.jar
67+
curl -fL --retry 3 -o conductor-server.jar \
68+
"https://repo1.maven.org/maven2/org/conductoross/conductor-server/${CONDUCTOR_OSS_VERSION}/conductor-server-${CONDUCTOR_OSS_VERSION}-boot.jar"
6169
6270
- name: Download CLI binary from release
6371
env:
6472
GH_TOKEN: ${{ github.token }}
6573
run: |
66-
gh release download "v${AGENTSPAN_VERSION}" --repo agentspan-ai/agentspan \
74+
gh release download "v${AGENTSPAN_CLI_VERSION}" --repo agentspan-ai/agentspan \
6775
--pattern "agentspan_linux_amd64" --output agentspan
6876
chmod +x agentspan
6977
@@ -80,7 +88,7 @@ jobs:
8088
8189
- name: Start server
8290
run: |
83-
java -jar agentspan-server.jar --server.port=8080 > server.log 2>&1 &
91+
java -jar conductor-server.jar --server.port=8080 > server.log 2>&1 &
8492
8593
- name: Wait for server health
8694
run: |

e2e/conftest.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -162,9 +162,10 @@ def get_task_by_name(execution_id: str, task_ref_prefix: str) -> list:
162162
# reason unrelated to the SDK. Probe the running server once and skip those tests
163163
# when unsupported.
164164
#
165-
# TODO: once agentspan cuts a release that implements runtimeMetadata, bump
166-
# AGENTSPAN_VERSION in .github/workflows/agent-e2e.yml — this guard then lets the
167-
# credential tests run automatically (no test change needed).
165+
# conductor-oss implements this from 3.32.0-rc.8 onward (see
166+
# .github/workflows/agent-e2e.yml's CONDUCTOR_OSS_VERSION) — this guard lets the
167+
# credential tests run automatically against any server that has it, no test
168+
# change needed.
168169

169170
_RUNTIME_METADATA_SUPPORT = None
170171

@@ -208,6 +209,6 @@ def requires_runtime_metadata():
208209
pytest.skip(
209210
"server does not persist/deliver TaskDef.runtimeMetadata "
210211
"(conductor-oss PR #1255) — worker credential injection requires it. "
211-
"TODO: bump AGENTSPAN_VERSION in .github/workflows/agent-e2e.yml once a "
212-
"release ships runtimeMetadata support."
212+
"Needs conductor-oss >= 3.32.0-rc.8 (see CONDUCTOR_OSS_VERSION in "
213+
".github/workflows/agent-e2e.yml)."
213214
)

0 commit comments

Comments
 (0)