Skip to content

Commit da74420

Browse files
committed
review comments
1 parent 5c92c4a commit da74420

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

tests/integration/client/orkes/test_orkes_service_registry_client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ def test_grpc_service(self):
140140
assert actual_service is not None, f"No service found with name: {GRPC_SERVICE_NAME}"
141141
assert actual_service.name == GRPC_SERVICE_NAME
142142
assert actual_service.type == ServiceType.GRPC.value
143-
assert actual_service.service_uri == "localhost:50051"
143+
assert actual_service.service_uri == "grpcbin:50051"
144144
assert len(actual_service.methods) == 0
145145

146146
initial_method_count = len(actual_service.methods)
@@ -196,7 +196,7 @@ def test_proto_operations(self):
196196
service_registry = ServiceRegistry()
197197
service_registry.name = GRPC_SERVICE_NAME + "_proto"
198198
service_registry.type = ServiceType.GRPC.value
199-
service_registry.service_uri = "localhost:50051"
199+
service_registry.service_uri = "grpcbin:50051"
200200

201201
self.client.add_or_update_service(service_registry)
202202

0 commit comments

Comments
 (0)