Skip to content

Commit db87528

Browse files
committed
fixes
1 parent af26e7e commit db87528

4 files changed

Lines changed: 17 additions & 17 deletions

File tree

src/conductor/client/event/task_events.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"""
77

88
from dataclasses import dataclass, field
9-
from datetime import datetime
9+
from datetime import datetime, timezone
1010

1111
from conductor.client.event.conductor_event import ConductorEvent
1212

@@ -33,7 +33,7 @@ class TaskResultPayloadSize(TaskEvent):
3333
timestamp: UTC timestamp when the event was created
3434
"""
3535
size_bytes: int
36-
timestamp: datetime = field(default_factory=datetime.utcnow)
36+
timestamp: datetime = field(default_factory=lambda: datetime.now(timezone.utc))
3737

3838

3939
@dataclass(frozen=True)
@@ -49,4 +49,4 @@ class TaskPayloadUsed(TaskEvent):
4949
"""
5050
operation: str
5151
payload_type: str
52-
timestamp: datetime = field(default_factory=datetime.utcnow)
52+
timestamp: datetime = field(default_factory=lambda: datetime.now(timezone.utc))

src/conductor/client/event/task_runner_events.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"""
77

88
from dataclasses import dataclass, field
9-
from datetime import datetime
9+
from datetime import datetime, timezone
1010
from typing import Optional
1111

1212
from conductor.client.event.conductor_event import ConductorEvent
@@ -37,7 +37,7 @@ class PollStarted(TaskRunnerEvent):
3737
"""
3838
worker_id: str
3939
poll_count: int
40-
timestamp: datetime = field(default_factory=datetime.utcnow)
40+
timestamp: datetime = field(default_factory=lambda: datetime.now(timezone.utc))
4141

4242

4343
@dataclass(frozen=True)
@@ -53,7 +53,7 @@ class PollCompleted(TaskRunnerEvent):
5353
"""
5454
duration_ms: float
5555
tasks_received: int
56-
timestamp: datetime = field(default_factory=datetime.utcnow)
56+
timestamp: datetime = field(default_factory=lambda: datetime.now(timezone.utc))
5757

5858

5959
@dataclass(frozen=True)
@@ -69,7 +69,7 @@ class PollFailure(TaskRunnerEvent):
6969
"""
7070
duration_ms: float
7171
cause: Exception
72-
timestamp: datetime = field(default_factory=datetime.utcnow)
72+
timestamp: datetime = field(default_factory=lambda: datetime.now(timezone.utc))
7373

7474

7575
@dataclass(frozen=True)
@@ -87,7 +87,7 @@ class TaskExecutionStarted(TaskRunnerEvent):
8787
task_id: str
8888
worker_id: str
8989
workflow_instance_id: Optional[str] = None
90-
timestamp: datetime = field(default_factory=datetime.utcnow)
90+
timestamp: datetime = field(default_factory=lambda: datetime.now(timezone.utc))
9191

9292

9393
@dataclass(frozen=True)
@@ -109,7 +109,7 @@ class TaskExecutionCompleted(TaskRunnerEvent):
109109
workflow_instance_id: Optional[str]
110110
duration_ms: float
111111
output_size_bytes: Optional[int] = None
112-
timestamp: datetime = field(default_factory=datetime.utcnow)
112+
timestamp: datetime = field(default_factory=lambda: datetime.now(timezone.utc))
113113

114114

115115
@dataclass(frozen=True)
@@ -131,4 +131,4 @@ class TaskExecutionFailure(TaskRunnerEvent):
131131
workflow_instance_id: Optional[str]
132132
cause: Exception
133133
duration_ms: float
134-
timestamp: datetime = field(default_factory=datetime.utcnow)
134+
timestamp: datetime = field(default_factory=lambda: datetime.now(timezone.utc))

src/conductor/client/event/workflow_events.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"""
77

88
from dataclasses import dataclass, field
9-
from datetime import datetime
9+
from datetime import datetime, timezone
1010
from typing import Optional
1111

1212
from conductor.client.event.conductor_event import ConductorEvent
@@ -41,7 +41,7 @@ class WorkflowStarted(WorkflowEvent):
4141
success: bool = True
4242
workflow_id: Optional[str] = None
4343
cause: Optional[Exception] = None
44-
timestamp: datetime = field(default_factory=datetime.utcnow)
44+
timestamp: datetime = field(default_factory=lambda: datetime.now(timezone.utc))
4545

4646

4747
@dataclass(frozen=True)
@@ -56,7 +56,7 @@ class WorkflowInputPayloadSize(WorkflowEvent):
5656
timestamp: UTC timestamp when the event was created
5757
"""
5858
size_bytes: int = 0
59-
timestamp: datetime = field(default_factory=datetime.utcnow)
59+
timestamp: datetime = field(default_factory=lambda: datetime.now(timezone.utc))
6060

6161

6262
@dataclass(frozen=True)
@@ -73,4 +73,4 @@ class WorkflowPayloadUsed(WorkflowEvent):
7373
"""
7474
operation: str = ""
7575
payload_type: str = ""
76-
timestamp: datetime = field(default_factory=datetime.utcnow)
76+
timestamp: datetime = field(default_factory=lambda: datetime.now(timezone.utc))

tests/unit/automator/utils_test.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ def printme(self):
3333
print(f'ba is: {self.ba} and all are {self.__dict__}')
3434

3535

36-
class Test:
36+
class SampleModel:
3737

3838
def __init__(self, a, b: List[SubTest], d: list[UserInfo], g: CaseInsensitiveDict[str, UserInfo]) -> None:
3939
self.a = a
@@ -57,9 +57,9 @@ def test_convert_non_dataclass(self):
5757
dictionary = {'a': 123, 'b': [{'ba': 2}, {'ba': 21}],
5858
'd': [{'name': 'conductor', 'id': 123}, {'F': 3}],
5959
'g': {'userA': {'name': 'userA', 'id': 100}, 'userB': {'name': 'userB', 'id': 101}}}
60-
value = convert_from_dict(Test, dictionary)
60+
value = convert_from_dict(SampleModel, dictionary)
6161

62-
self.assertEqual(Test, type(value))
62+
self.assertEqual(SampleModel, type(value))
6363
self.assertEqual(123, value.a)
6464
self.assertEqual(2, len(value.b))
6565
self.assertEqual(21, value.b[1].ba)

0 commit comments

Comments
 (0)