Commit e4d0eb5
fix: auto-start workers in context manager and warn on RUNNING+failed tasks
- TaskHandler.__enter__ now calls start_processes() so `with TaskHandler(...)
as h:` works out of the box without a separate h.start_processes() call.
start_processes() is idempotent via _processes_started guard, so existing
code that calls it explicitly inside the with-block is unaffected.
Fixes conductor-oss/getting-started#42.
- WorkflowExecutor.execute() and execute_workflow() now log a WARNING when
the workflow returns RUNNING after the wait timeout but a task is already
in FAILED/FAILED_WITH_TERMINAL_ERROR state, surfacing the failure reason
that would otherwise be invisible to the caller.
Fixes conductor-oss/getting-started#41.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>1 parent e5ff5cd commit e4d0eb5
3 files changed
Lines changed: 38 additions & 2 deletions
File tree
- src/conductor/client
- automator
- workflow/executor
- tests/unit/automator
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
325 | 325 | | |
326 | 326 | | |
327 | 327 | | |
| 328 | + | |
328 | 329 | | |
329 | 330 | | |
330 | 331 | | |
| 332 | + | |
331 | 333 | | |
332 | 334 | | |
333 | 335 | | |
| |||
341 | 343 | | |
342 | 344 | | |
343 | 345 | | |
| 346 | + | |
344 | 347 | | |
345 | 348 | | |
346 | 349 | | |
347 | 350 | | |
348 | 351 | | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
349 | 355 | | |
350 | 356 | | |
351 | 357 | | |
| |||
Lines changed: 18 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
2 | 3 | | |
3 | 4 | | |
4 | 5 | | |
| 6 | + | |
| 7 | + | |
5 | 8 | | |
6 | 9 | | |
7 | 10 | | |
| |||
122 | 125 | | |
123 | 126 | | |
124 | 127 | | |
125 | | - | |
| 128 | + | |
126 | 129 | | |
127 | 130 | | |
128 | 131 | | |
129 | 132 | | |
130 | 133 | | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
131 | 148 | | |
132 | 149 | | |
133 | 150 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
663 | 663 | | |
664 | 664 | | |
665 | 665 | | |
666 | | - | |
| 666 | + | |
| 667 | + | |
667 | 668 | | |
668 | 669 | | |
669 | 670 | | |
670 | 671 | | |
671 | 672 | | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
672 | 679 | | |
673 | 680 | | |
674 | 681 | | |
| |||
679 | 686 | | |
680 | 687 | | |
681 | 688 | | |
| 689 | + | |
| 690 | + | |
| 691 | + | |
| 692 | + | |
682 | 693 | | |
683 | 694 | | |
684 | 695 | | |
685 | 696 | | |
| 697 | + | |
| 698 | + | |
686 | 699 | | |
687 | 700 | | |
688 | 701 | | |
| |||
0 commit comments