Add /api/workflow/execute/{name}/{version} support in sdk#292
Closed
orkes-harshil wants to merge 12 commits into
Closed
Add /api/workflow/execute/{name}/{version} support in sdk#292orkes-harshil wants to merge 12 commits into
orkes-harshil wants to merge 12 commits into
Conversation
orkes-harshil
changed the title
| (data) = self.execute_workflow_reactive_with_http_info(body, name, version, **kwargs) # noqa: E501 | ||
| return data | ||
|
|
||
| def execute_workflow_reactive_with_http_info(self, body, name, version, **kwargs): # noqa: E501 |
There was a problem hiding this comment.
Any idea why we say reactive in method name ? execute_workflow_reactive_with_http_info
Contributor
Author
There was a problem hiding this comment.
yes -this is not needed
Contributor
Author
There was a problem hiding this comment.
i'll change this
| sleep(1 << attempt) | ||
|
|
||
|
|
||
| def test_execute_workflow_reactive_features(workflow_executor: WorkflowExecutor): |
There was a problem hiding this comment.
Unable to understand reactive_feature in method name. For better understanding for others lets add something in description or we can change then name!
Co-authored-by: Shailesh Padave <shaileshpadave49@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.