fix: lease heartbeat 500 error and remove fork override in tests#415
Open
shaileshpadave wants to merge 1 commit into
Open
fix: lease heartbeat 500 error and remove fork override in tests#415shaileshpadave wants to merge 1 commit into
shaileshpadave wants to merge 1 commit into
Conversation
- Send IN_PROGRESS status in lease extension heartbeats to prevent
NullPointerException on the server when getStatus() is called
- Remove set_start_method('fork', force=True) from integration test
that was overriding the SDK's spawn default for the whole test session
and causing SIGSEGV crashes on macOS
Found during macOS spawn-safety testing (Python 3.11/3.13/3.14).
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two bugs found during macOS spawn-safety testing.
1. Lease heartbeat → 500 on server
Heartbeat was sent without a
statusfield. Server NPEs callinggetStatus().name()when status is null. Fixed by includingstatus=IN_PROGRESSin heartbeat requests.2. Integration test forces fork, breaks spawn default
test_workflow_execution.pyhadset_start_method('fork', force=True)which overrode the SDK's spawn default for the whole pytest session, causing SIGSEGV crashes on macOS for subsequent tests. Removed.Tested