Skip to content

Commit b3cf76e

Browse files
committed
fix ajax_playground
1 parent 54cbaa8 commit b3cf76e

3 files changed

Lines changed: 27 additions & 19 deletions

File tree

examples/cone.example/src/cone/example/ajax/browser.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,16 @@
11
from cone.app.browser.ajax import ajax_continue
22
from cone.app.browser.ajax import ajax_message
3-
from cone.app.browser.ajax import ajax_status_message
43
from cone.app.browser.ajax import AjaxAction
54
from cone.app.browser.ajax import AjaxEvent
65
from cone.app.browser.ajax import AjaxMessage
7-
from cone.app.browser.ajax import AjaxOverlay
86
from cone.app.browser.ajax import AjaxPath
97
from cone.app.browser.layout import ProtectedContentTile
108
from cone.app.browser.utils import make_url
11-
from cone.app.model import AppNode
129
from cone.app.model import BaseNode
1310
from cone.app.model import Metadata
14-
from cone.app.model import Properties
1511
from cone.app.model import node_info
12+
from cone.app.model import Properties
13+
from cone.app.utils import node_path
1614
from cone.example.model import _
1715
from cone.tile import tile
1816
from node.utils import instance_property
@@ -87,12 +85,13 @@ def render(self):
8785
interface=AjaxPlayground,
8886
permission='view')
8987
class AjaxPathDemo(ProtectedContentTile):
88+
# XXX: make this demo more obvious, e.g. by changing some content
9089

9190
def render(self):
9291
url = make_url(self.request, node=self.model)
9392
ajax_continue(self.request, [
9493
AjaxPath(
95-
path='/'.join(self.model.path),
94+
path='/'.join(node_path(self.model)),
9695
target=url,
9796
event='contextchanged:#layout'
9897
)
@@ -105,6 +104,7 @@ def render(self):
105104
interface=AjaxPlayground,
106105
permission='view')
107106
class AjaxEventDemo(ProtectedContentTile):
107+
# XXX: make this demo more obvious, e.g. by changing some content
108108

109109
def render(self):
110110
url = make_url(self.request, node=self.model)
@@ -148,12 +148,14 @@ def render(self):
148148
interface=AjaxPlayground,
149149
permission='view')
150150
class AjaxCombinedDemo(ProtectedContentTile):
151+
# XXX: this makes little sense, as the AjaxAction will be overridden
152+
# by the AjaxEvent. Find a better combination demo.
151153

152154
def render(self):
153155
url = make_url(self.request, node=self.model)
154156
ajax_continue(self.request, [
155157
AjaxAction(url, 'ajax_demo_content', 'inner', '#ajax-demo-target'),
156-
AjaxMessage('Combined: action + message + event!', 'success'),
158+
AjaxMessage('Combined: action + message + event!', 'success', None),
157159
AjaxEvent(url, 'contextchanged', '#layout'),
158160
])
159161
return ''

examples/cone.example/src/cone/example/ajax/templates/ajax_playground.pt

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
<tal:view xmlns:tal="http://xml.zope.org/namespaces/tal"
2-
omit-tag="True">
2+
xmlns:ajax="http://namespaces.conestack.org/ajax"
3+
omit-tag="True">
34

45
<tal:contextmenu replace="structure tile('contextmenu')" />
56

@@ -31,8 +32,9 @@
3132
</p>
3233
<a href="#"
3334
class="btn btn-outline-primary btn-sm ajax"
34-
tal:attributes="ajax:target view.ajax_path_url;
35-
ajax:action 'ajax_path_demo:NONE:NONE'">
35+
ajax:bind="click"
36+
ajax:target="${context.ajax_path_url}"
37+
ajax:action="ajax_path_demo:NONE:NONE">
3638
Trigger AjaxPath
3739
</a>
3840
</div>
@@ -51,8 +53,9 @@
5153
</p>
5254
<a href="#"
5355
class="btn btn-outline-primary btn-sm ajax"
54-
tal:attributes="ajax:target view.ajax_action_url;
55-
ajax:action 'ajax_action_demo:NONE:NONE'">
56+
ajax:bind="click"
57+
ajax:target="${context.ajax_action_url}"
58+
ajax:action="ajax_action_demo:NONE:NONE">
5659
Trigger AjaxAction
5760
</a>
5861
</div>
@@ -72,8 +75,9 @@
7275
</p>
7376
<a href="#"
7477
class="btn btn-outline-primary btn-sm ajax"
75-
tal:attributes="ajax:target view.ajax_action_url;
76-
ajax:action 'ajax_event_demo:NONE:NONE'">
78+
ajax:bind="click"
79+
ajax:target="${context.ajax_action_url}"
80+
ajax:action="ajax_event_demo:NONE:NONE">
7781
Trigger AjaxEvent
7882
</a>
7983
</div>
@@ -93,8 +97,9 @@
9397
</p>
9498
<a href="#"
9599
class="btn btn-outline-primary btn-sm ajax"
96-
tal:attributes="ajax:target view.ajax_action_url;
97-
ajax:action 'ajax_message_demo:NONE:NONE'">
100+
ajax:bind="click"
101+
ajax:target="${context.ajax_action_url}"
102+
ajax:action="ajax_message_demo:NONE:NONE">
98103
Trigger AjaxMessage
99104
</a>
100105
</div>
@@ -114,8 +119,9 @@
114119
</p>
115120
<a href="#"
116121
class="btn btn-outline-success btn-sm ajax"
117-
tal:attributes="ajax:target view.ajax_action_url;
118-
ajax:action 'ajax_combined_demo:NONE:NONE'">
122+
ajax:bind="click"
123+
ajax:target="${context.ajax_action_url}"
124+
ajax:action="ajax_combined_demo:NONE:NONE">
119125
Trigger Combined
120126
</a>
121127
</div>

examples/cone.example/src/cone/example/project/browser.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ class ProjectAddForm(ProjectForm):
203203
def save(self, widget, data):
204204
from cone.app.browser.utils import choose_name
205205
add_creation_metadata(self.request, self.model.attrs)
206-
super().save(widget, data)
206+
super(ProjectAddForm, self).save(widget, data)
207207
parent = self.model.parent
208208
parent[choose_name(parent, self.model.metadata.title)] = self.model
209209

@@ -213,7 +213,7 @@ class ProjectEditForm(ProjectForm):
213213

214214
def save(self, widget, data):
215215
update_creation_metadata(self.request, self.model.attrs)
216-
super().save(widget, data)
216+
super(ProjectEditForm, self).save(widget, data)
217217

218218

219219
# For Task add form, we need to create a TaskData and wrap in Task

0 commit comments

Comments
 (0)