Remove Docker provider#3074
Conversation
03d8702 to
7000796
Compare
|
@Amulyam24 can you rebase this PR? |
Hi @mkulke, rebased the PR, PTAL, Thanks! |
|
Hi @Amulyam24 , thanks for raising this PR! Just for general awareness, @stevenhorsman is working to get the release 0.21 done but the removal of the docker provider is planned only for 0.22. |
|
@Amulyam24 headsup: I rebased the PR via github, it still has a "hold" tag. so, we want to wait for the release to go through. but the tests should in theory start to turn green now. |
|
another rebase required and the mkosi Makefiles still seem to reference some docker files, see failed e2e tests. we can use "git grep docker" to find references. |
566080f to
91ba282
Compare
stevenhorsman
left a comment
There was a problem hiding this comment.
LGTM. Unfortunately do to the badly timed merge you will need to resolve the conflict, but after that this is good to go. Thanks for the update!
|
@copilot resolve the merge conflicts in this pull request |
|
oh, copilot can't fix problems on forks (lucklily) |
Signed-off-by: Amulyam24 <amulmek1@in.ibm.com>
Signed-off-by: Amulyam24 <amulmek1@in.ibm.com>
Signed-off-by: Amulyam24 <amulmek1@in.ibm.com>
Signed-off-by: Amulyam24 <amulmek1@in.ibm.com>
Signed-off-by: Amulyam24 <amulmek1@in.ibm.com>
Signed-off-by: Amulyam24 <amulmek1@in.ibm.com>
Signed-off-by: Amulyam24 <amulmek1@in.ibm.com>
|
Rebased the PR, PTAL! |
Docker provider has been deprecated and this PR aims to remove it.
Note: dependent on #3071 to be merged