Skip to content

Remove Docker provider#3074

Merged
mkulke merged 7 commits into
confidential-containers:mainfrom
Amulyam24:remove-docker
Jun 2, 2026
Merged

Remove Docker provider#3074
mkulke merged 7 commits into
confidential-containers:mainfrom
Amulyam24:remove-docker

Conversation

@Amulyam24

Copy link
Copy Markdown
Contributor

Docker provider has been deprecated and this PR aims to remove it.

Note: dependent on #3071 to be merged

@Amulyam24 Amulyam24 requested a review from a team as a code owner May 19, 2026 07:52
@Amulyam24 Amulyam24 force-pushed the remove-docker branch 2 times, most recently from 03d8702 to 7000796 Compare May 19, 2026 08:11
@mkulke

mkulke commented May 23, 2026

Copy link
Copy Markdown
Collaborator

@Amulyam24 can you rebase this PR?

@Amulyam24

Copy link
Copy Markdown
Contributor Author

@Amulyam24 can you rebase this PR?

Hi @mkulke, rebased the PR, PTAL, Thanks!

@mkulke mkulke added the test_e2e_libvirt Run Libvirt e2e tests label May 26, 2026
@wainersm

Copy link
Copy Markdown
Member

Hi @Amulyam24 , thanks for raising this PR! Just for general awareness, @stevenhorsman is working to get the release 0.21 done but the removal of the docker provider is planned only for 0.22.

@mkulke

mkulke commented May 26, 2026

Copy link
Copy Markdown
Collaborator

@Amulyam24 headsup: I rebased the PR via github, it still has a "hold" tag. so, we want to wait for the release to go through. but the tests should in theory start to turn green now.

@mkulke

mkulke commented May 27, 2026

Copy link
Copy Markdown
Collaborator

another rebase required and the mkosi Makefiles still seem to reference some docker files, see failed e2e tests. we can use "git grep docker" to find references.

@Amulyam24 Amulyam24 force-pushed the remove-docker branch 3 times, most recently from 566080f to 91ba282 Compare May 27, 2026 16:21
Comment thread .github/workflows/podvm_mkosi.yaml

@stevenhorsman stevenhorsman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Unfortunately do to the badly timed merge you will need to resolve the conflict, but after that this is good to go. Thanks for the update!

@mkulke

mkulke commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

@copilot resolve the merge conflicts in this pull request

@mkulke

mkulke commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

oh, copilot can't fix problems on forks (lucklily)

Amulyam24 added 7 commits June 2, 2026 10:59
Signed-off-by: Amulyam24 <amulmek1@in.ibm.com>
Signed-off-by: Amulyam24 <amulmek1@in.ibm.com>
Signed-off-by: Amulyam24 <amulmek1@in.ibm.com>
Signed-off-by: Amulyam24 <amulmek1@in.ibm.com>
Signed-off-by: Amulyam24 <amulmek1@in.ibm.com>
Signed-off-by: Amulyam24 <amulmek1@in.ibm.com>
Signed-off-by: Amulyam24 <amulmek1@in.ibm.com>
@Amulyam24

Copy link
Copy Markdown
Contributor Author

Rebased the PR, PTAL!

@Amulyam24 Amulyam24 removed the hold label Jun 2, 2026
@mkulke mkulke merged commit 8916afe into confidential-containers:main Jun 2, 2026
81 of 91 checks passed
@Amulyam24 Amulyam24 mentioned this pull request Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test_e2e_libvirt Run Libvirt e2e tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants