peerpod-ctrl: register gcp cloud provider#3076
Open
PeteE wants to merge 1 commit into
Open
Conversation
Signed-off-by: Pete Erickson <pete@opaque.co>
3cafa4d to
270c06b
Compare
PeteE
added a commit
to opaque-systems/cloud-api-adaptor
that referenced
this pull request
May 19, 2026
bpradipt
approved these changes
May 20, 2026
Author
Yes I will verify today and post results! |
Member
beraldoleal
approved these changes
May 26, 2026
Member
beraldoleal
left a comment
There was a problem hiding this comment.
LGTM, thanks. Needs a rebase tho.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/peerpod-ctrl/controllers/gcp.go, a//go:build gcpblank import ofcloud-providers/gcp, mirroring the existingaws.go/azure.go/libvirt.go/ibmcloud.go/alibabacloud.go/byom.goregistration files in the same package.-tags gcpcompiles successfully but the GCP cloud-provider'sinit()is never linked in, socloud.GetProvider("gcp")returns nothing and peerpod-ctrl cannot delete peer-pod VMs on GCP.go.mod/go.sumchanges are produced bygo mod tidyafter adding the import — every new entry carries// indirectbecause peerpod-ctrl only reaches the GCP SDK transitively through the cloud-providers/gcp package.Motivation
Observed in a live GKE cluster running peerpod-ctrl built with
-tags gcp. When a peer-pod is torn down, the reconciler logs:"gcp cloud provider not supported"is the error returned when the provider registry has nogcpentry. With this blank import in place under thegcpbuild tag, the registry is populated and the reconciler succeeds.Test plan
go build -tags gcp ./...insrc/peerpod-ctrl/succeedsgo mod tidyproduces no further changes after the import is added-tags gcpon GKE, delete a peer-pod, confirm the reconciler no longer returnsgcp cloud provider not supported🤖 Generated with Claude Code