Add focused unit tests for libvirt image management#3093
Merged
stevenhorsman merged 1 commit intoJun 2, 2026
Merged
Conversation
chathuryaadapa
force-pushed
the
libvirt-tests-image
branch
from
May 25, 2026 08:17
1a6d8a0 to
48d140d
Compare
chathuryaadapa
force-pushed
the
libvirt-tests-image
branch
from
June 1, 2026 15:05
ca2ec14 to
b14db69
Compare
mkulke
approved these changes
Jun 2, 2026
Implements comprehensive yet focused unit tests for the inMemoryImage implementation in the libvirt provider. Tests cover: - Image creation from byte arrays (text, empty, binary data) - Size calculation functionality - String representation - Import operations with success and error handling Test coverage: - TestInMemoryImage: Validates creation, size(), and string() methods - TestInMemoryImageImport: Tests importImage with various scenarios Signed-off-by: Chathurya Adapa <Adapa.Chathurya1@ibm.com> Assisted-by: IBM Bob <noreply@ibm.com>
mkulke
force-pushed
the
libvirt-tests-image
branch
from
June 2, 2026 09:09
b14db69 to
9a276be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements comprehensive yet focused unit tests for the inMemoryImage implementation in the libvirt provider.
Tests cover:
Test coverage:
Assisted-by: IBM Bob noreply@ibm.com