Few fixes that got missed out during Fedora to Ubuntu mkosi image migration#3100
Open
bpradipt wants to merge 2 commits into
Open
Few fixes that got missed out during Fedora to Ubuntu mkosi image migration#3100bpradipt wants to merge 2 commits into
bpradipt wants to merge 2 commits into
Conversation
Ubuntu's openssh-server does not ship sshd-keygen@.service, so the existing Fedora-style override has no effect. Add ssh-host-keys.service (oneshot) to generate rsa/ecdsa/ed25519 keys in /run/ssh, a ssh.service drop-in to order ssh.service after key generation, and a systemd preset to enable ssh.service Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
Ubuntu's openssh-server does not ship sshd-keygen@.service, so the existing sshd-keygen@.service.d override in mkosi.skeleton-sftp has no effect on Ubuntu. Add ssh-host-keys.service (oneshot) and a ssh.service drop-in using the same pattern introduced for the debug image, so host keys are generated in /run/ssh before ssh.service starts. The sshd-keygen@.service.d override is retained for Fedora. Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
Member
|
@bpradipt - thanks for the updates. Do you think they need to go into 0.21.1, or are they okay to be in the dev code (e.g. for the debug image fix) until 0.22 release? |
Member
Author
No need for this to go in 0.21.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.