Skip to content

Explicitly Export PartitionMetadata to Satisfy Type Checkers #2225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
George Berdovskiy (george-sentry) wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Explicitly Export PartitionMetadata to Satisfy Type Checkers #2225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/confluent_kafka/admin/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@
from ._listoffsets import ListOffsetsResultInfo # noqa: F401
from ._listoffsets import OffsetSpec # noqa: F401
from ._metadata import BrokerMetadata # noqa: F401
from ._metadata import ClusterMetadata, GroupMember, GroupMetadata, PartitionMetadata, TopicMetadata # noqa: F401
from ._metadata import ClusterMetadata, GroupMember, GroupMetadata, TopicMetadata # noqa: F401
from ._metadata import PartitionMetadata as PartitionMetadata # noqa: F401
Comment on lines 75 to +77
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds an explicit re-export for PartitionMetadata, but the rest of the re-exported symbols in this module are still implicit from a type-checker perspective. To avoid having to special-case additional symbols later (and to make the public surface area unambiguous), consider defining an explicit __all__ for the admin package (or consistently using from ... import X as X for all intended re-exports).

Copilot uses AI. Check for mistakes.
from ._records import DeletedRecords # noqa: F401
from ._resource import ResourcePatternType # noqa: F401
from ._resource import ResourceType # noqa: F401
Expand Down
Loading