[KIP-932] Implement acknowledgement RPC#2239
Conversation
Kaushik Raina (k-raina)
requested review from
a team and
Matthew Seal (MSeal)
as code owners
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
airlock-confluentinc
Bot
force-pushed
the
dev_kip-932_share_consumer_ack
branch
from
1043228 to
09fb66d
Compare
|
|
Unrelated test failure as per base branch #2217 (comment) |
Pratyush Ranjan (PratRanj07)
left a comment
Pratyush Ranjan (PratRanj07)
left a comment
There was a problem hiding this comment.
Some nits
| /** | ||
| * @brief Acknowledge previously polled message. | ||
| * | ||
| * Internally delegates to rd_kafka_share_acknowledge_offset() because the | ||
| * Python Message object does not retain the underlying rd_kafka_message_t | ||
| * pointer (Message_new0 copies fields out and destroys the rkm) | ||
| */ |
There was a problem hiding this comment.
Maybe add a TODO to check whether we should match the Java functionality that we should only acknowledge the successful messages with this API and the error messages with the offset API?
Like for the case of Java, they throw an error if the successful messages are processed with the offset API. I think that decision will be finalised once we have the discussion on the differences between the Java clients and the NJC clients
Ojasva Jain (ojasvajain)
left a comment
Ojasva Jain (ojasvajain)
left a comment
There was a problem hiding this comment.
I have resolved my earlier comments. Thanks.
Just one minor comment.
| @@ -0,0 +1,591 @@ | |||
| #!/usr/bin/env python | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
We should add license details
3 participants
Summary
ShareConsumer.acknowledge() andacknowledge_offset(), explicit-mode acknowledgement APIs in the C extension. . Internally delegates tord_kafka_share_acknowledge_offset()to work around Message not retaining the underlying rd_kafka_message_t.