Skip to content

fix: align KafkaError stub keyword with runtime #2278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wgu9 (wgu9) wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: align KafkaError stub keyword with runtime #2278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/confluent_kafka/cimpl.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ class KafkaError:
_WAIT_COORD: int
def __init__(
self,
code: int,
error: int,
reason: Optional[str] = None,
fatal: bool = False,
retriable: bool = False,
Expand Down
8 changes: 8 additions & 0 deletions tests/test_kafka_error.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,14 @@ def test_kafkaError_custom_msg():
assert not err.txn_requires_abort()


def test_kafkaError_init_keyword_matches_runtime_signature():
err = KafkaError(error=KafkaError._ALL_BROKERS_DOWN)
assert err == KafkaError._ALL_BROKERS_DOWN

with pytest.raises(TypeError):
KafkaError(code=KafkaError._ALL_BROKERS_DOWN)


def test_kafkaError_unknown_error():
with pytest.raises(KafkaException, match="Err-12345?") as e:
raise KafkaError(12345)
Expand Down