Skip to content

[KIP-932] - Update ShareConsumer Api docs#2295

Open
Kaushik Raina (k-raina) wants to merge 1 commit into
masterfrom
dev_kip-932_queues-for-kafka_api_docs
Open

[KIP-932] - Update ShareConsumer Api docs#2295
Kaushik Raina (k-raina) wants to merge 1 commit into
masterfrom
dev_kip-932_queues-for-kafka_api_docs

Conversation

@k-raina

Copy link
Copy Markdown
Member

Summary

  • Update API docs for share consumer

Copilot AI review requested due to automatic review settings June 26, 2026 08:49
@confluent-cla-assistant

Copy link
Copy Markdown

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the ShareConsumer user-facing API documentation (C-embedded docstrings) to reflect KIP-932 behavior and clarify usage/semantics for subscription, polling, acknowledgements, shutdown, and thread-safety expectations.

Changes:

  • Expanded method docstrings for subscribe(), poll(), acknowledge() / acknowledge_offset(), and close() with clearer behavioral details and error conditions.
  • Added high-level ShareConsumer class documentation describing record lock/acknowledgement modes, polling requirements, and explicit thread-safety warnings.
  • Removed the outdated internal TODO block in favor of user-facing documentation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sonarqube-confluent

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants