use hasPresence instead of proto3 checks#3926
Open
Nas Denkov (ubiquitousbyte) wants to merge 3 commits into
Open
use hasPresence instead of proto3 checks#3926Nas Denkov (ubiquitousbyte) wants to merge 3 commits into
Nas Denkov (ubiquitousbyte) wants to merge 3 commits into
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
2dc4422 to
15394e8
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the protobuf converter to use the hasPresence() method instead of checking for proto3Optional() when determining if a field is optional. This change addresses field-presence tracking issues in Kafka Connect when working with Protobuf messages.
- Replaces proto3-specific optional check with a more general presence check
- Improves field-presence handling for protobuf messages in Kafka Connect
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
|
/sem-approve |
Member
|
/sem-approve |
Author
|
Hey Robert Yokota (@rayokota), is there anything I need to do to advance this forward? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
See #3925
Checklist
Please answer the questions with Y, N or N/A if not applicable.
References
#3569
Test & Review
Haven't tested it. Only found the bug by using the FileStreamSinkConnector with a Protobuf message similar to the one described in the issue and seeing that field-presence tracking is not respected by Kafka Connect.
Open questions / Follow-ups
Should this be gate-kept by a feature flag?
Review stakeholders
Robert Yokota (@rayokota)