chore(release): fix release publishing step#170
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the release publishing automation to explicitly validate that a release PR’s required checks are present and have all passed before proceeding, addressing reliability of the publish gate.
Changes:
- Replace
gh pr checks --fail-fastusage with JSON-based required-check evaluation viajq. - Fail publishing when no required checks are reported, or when any required check is not in the
"pass"bucket. - Update the Bats test stub and assertion to reflect the new
gh pr checks --json ...invocation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/scripts/publish-release.sh | Adds explicit parsing/validation of required PR checks before tagging and pushing. |
| .github/tests/release-scripts.bats | Extends gh stub to support pr checks and updates the publish-release test assertion. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kruton
force-pushed
the
publish-action-fix
branch
from
4d02a3d to
e7482ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.