Skip to content

Commit 4db490e

Browse files
Update github.com/bufbuild/protoplugin digest to 25d1d28 (#220)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Stefan VanBuren <svanburen@buf.build>
1 parent 2477b0f commit 4db490e

6 files changed

Lines changed: 46 additions & 24 deletions

File tree

.github/workflows/ci.yaml

Lines changed: 18 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ concurrency:
1717
cancel-in-progress: true
1818

1919
jobs:
20-
build:
20+
ci:
2121
runs-on: ${{ matrix.os }}
2222
strategy:
2323
matrix:
@@ -57,6 +57,8 @@ jobs:
5757

5858
steps:
5959
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
60+
with:
61+
persist-credentials: false
6062

6163
- uses: astral-sh/setup-uv@08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0
6264
with:
@@ -73,28 +75,28 @@ jobs:
7375
if: startsWith(matrix.os, 'ubuntu-')
7476
run: uv run poe lint
7577

78+
- name: check running generate does not create a diff
79+
# NOTE: running on macOS as our sed command only works there
80+
# We expect uv.lock to change when matrix.resolution == "lowest-direct", so we don't check it there.
81+
if: ${{ startsWith(matrix.os, 'macos-') && matrix.resolution == 'highest' }}
82+
run: uv run poe checkgenerate
83+
env:
84+
BUF_TOKEN: ${{ secrets.BUF_TOKEN }}
85+
7686
- name: run python tests
7787
run: uv run poe test ${{ matrix.coverage == 'cov' && '--cov=connectrpc --cov-report=xml' || '' }}
7888

79-
- name: run conformance tests
80-
# TODO: Debug stdin/stdout issues on Windows
81-
if: ${{ !startsWith(matrix.os, 'windows-') }}
82-
run: uv run poe test-conformance ${{ matrix.coverage == 'cov' && '--cov=connectrpc --cov-report=xml' || '' }}
83-
8489
- name: run OTel tests
8590
run: uv run poe test-otel ${{ matrix.coverage == 'cov' && '--cov=connectrpc_otel --cov-report=xml' || '' }}
8691

8792
- name: run Go tests
8893
run: go test ./...
8994
working-directory: protoc-gen-connect-python
9095

91-
- name: check running generate does not create a diff
92-
# NOTE: running on macOS as our sed command only works there
93-
# We expect uv.lock to change when matrix.resolution == "lowest-direct", so we don't check it there.
94-
if: ${{ startsWith(matrix.os, 'macos-') && matrix.resolution == 'highest' }}
95-
run: uv run poe checkgenerate
96-
env:
97-
BUF_TOKEN: ${{ secrets.BUF_TOKEN }}
96+
- name: run conformance tests
97+
# TODO: Debug stdin/stdout issues on Windows
98+
if: ${{ !startsWith(matrix.os, 'windows-') }}
99+
run: uv run poe test-conformance ${{ matrix.coverage == 'cov' && '--cov=connectrpc --cov-report=xml' || '' }}
98100

99101
- uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0
100102
if: ${{ matrix.coverage == 'cov' }}
@@ -103,9 +105,11 @@ jobs:
103105

104106
publish:
105107
runs-on: ubuntu-24.04
106-
needs: build
108+
needs: ci
107109
steps:
108110
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
111+
with:
112+
persist-credentials: false
109113

110114
- uses: astral-sh/setup-uv@08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0
111115

poe_tasks.toml

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
#:schema https://json.schemastore.org/partial-poe.json
22

3-
[env]
4-
BUF_VERSION = "v1.67.0"
5-
63
[tasks.bump]
74
help = "Bump the project version"
85
sequence = [
@@ -58,29 +55,30 @@ sequence = [
5855
"generate-example",
5956
"generate-status",
6057
"generate-test",
58+
{ cmd = "go mod tidy", cwd = "protoc-gen-connect-python" },
6159
"format",
6260
]
6361

6462
[tasks.generate-conformance]
6563
help = "Generate conformance files"
6664
sequence = [
67-
{ cmd = "go run github.com/bufbuild/buf/cmd/buf@${BUF_VERSION} generate" },
65+
{ cmd = "buf generate" },
6866
{ shell = "find test/gen -type f -exec sed -i '' 's/from connectrpc.conformance.v1/from gen.connectrpc.conformance.v1/' {} +", env = { "LC_ALL" = "c" } },
6967
]
7068
cwd = "conformance"
7169

7270
[tasks.generate-example]
7371
help = "Generate example files"
74-
cmd = "go run github.com/bufbuild/buf/cmd/buf@${BUF_VERSION} generate"
72+
cmd = "buf generate"
7573
cwd = "example"
7674

7775
[tasks.generate-status]
7876
help = "Generate gRPC status"
79-
cmd = "go run github.com/bufbuild/buf/cmd/buf@${BUF_VERSION} generate"
77+
cmd = "buf generate"
8078

8179
[tasks.generate-test]
8280
help = "Generate test files"
83-
cmd = "go run github.com/bufbuild/buf/cmd/buf@${BUF_VERSION} generate"
81+
cmd = "buf generate"
8482
cwd = "test"
8583

8684
[tasks.lint]

protoc-gen-connect-python/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@ module github.com/connectrpc/connect-python/protoc-gen-connect-python
33
go 1.25.7
44

55
require (
6-
github.com/bufbuild/protoplugin v0.0.0-20250218205857-750e09ce93e1
6+
github.com/bufbuild/protoplugin v0.0.0-20260414125817-25d1d281b46b
77
google.golang.org/protobuf v1.36.11
88
)

protoc-gen-connect-python/go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
github.com/bufbuild/protocompile v0.14.1 h1:iA73zAf/fyljNjQKwYzUHD6AD4R8KMasmwa/FBatYVw=
22
github.com/bufbuild/protocompile v0.14.1/go.mod h1:ppVdAIhbr2H8asPk6k4pY7t9zB1OU5DoEw9xY/FUi1c=
3-
github.com/bufbuild/protoplugin v0.0.0-20250218205857-750e09ce93e1 h1:V1xulAoqLqVg44rY97xOR+mQpD2N+GzhMHVwJ030WEU=
4-
github.com/bufbuild/protoplugin v0.0.0-20250218205857-750e09ce93e1/go.mod h1:c5D8gWRIZ2HLWO3gXYTtUfw/hbJyD8xikv2ooPxnklQ=
3+
github.com/bufbuild/protoplugin v0.0.0-20260414125817-25d1d281b46b h1:b7wvo9ZhjLzCp7tGbOUMvgtYTnd33zGSAmMxcdxMnhQ=
4+
github.com/bufbuild/protoplugin v0.0.0-20260414125817-25d1d281b46b/go.mod h1:c5D8gWRIZ2HLWO3gXYTtUfw/hbJyD8xikv2ooPxnklQ=
55
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
66
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
77
github.com/google/go-cmp v0.7.0 h1:wk8382ETsv4JYUZwIsn6YpYiWiBsYLSJiTsyBybVuN8=

pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ dev = [
4242
"Twisted[tls,http2]==25.5.0",
4343
"asgiref==3.11.1",
4444
"brotli==1.2.0",
45+
"buf-bin==1.68.3",
4546
"connect-python-example",
4647
"daphne==4.2.1",
4748
"granian==2.7.3",

uv.lock

Lines changed: 19 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)