Migrate connect-python to protobuf-py and connect-py#373
Conversation
Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
|
@anuraaga is attempting to deploy a commit to the connectrpc Team on Vercel. A member of the Team first needs to authorize it. |
stefanvanburen
left a comment
stefanvanburen
left a comment
There was a problem hiding this comment.
thought I left this review yesterday, but just adding these comments here - I think these APIs need fixing but otherwise 🚢
There was a problem hiding this comment.
are these APIs still correct with protobuf-py? just double-checking
|
|
||
| ### Standard error detail types | ||
|
|
||
| With `googleapis-common-protos` installed, you can use standard types like: |
There was a problem hiding this comment.
might be worth adding a replacement for these at some point, since they can still structurally be the same (without needing the same package)
There was a problem hiding this comment.
Yup - I think the best we can do for now is delete this section but we'll need to see how to deal with it in the long term.
Personally, I've never considered using these protos ;)
Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
2 participants
This migrates the docs for connectrpc/connect-py#274. It largely follows the strategy of matching connect-es's style of using Connect by itself instead of Connect-Python in prose and fixing up repo links.