fix: stop buttons opening keyboard on Android

Remove e.preventDefault() from touchend in onTap and all handler sites.

preventDefault() on touchend blocks the browser from synthesising
mousedown, which prevents focus transfer from the terminal textarea
to the button. On Android, the terminal retains focus and the keyboard
re-shows on every button press.

Safe to remove because:
- touchFired guard already prevents double-execution
- touch-action: manipulation in CSS handles double-tap zoom
- preventDefault() on <button> outside forms is a no-op for click

Adds regression test verifying touchend is not defaultPrevented.

Author: connorads

src/controls/combo-picker.ts

@@ -281,14 +281,12 @@ export function createComboPicker(): ComboPickerResult {
 		closeAndFocus()
 	})
 
-	onTap(cancelButton, (event: Event) => {
-		event.preventDefault()
+	onTap(cancelButton, () => {
 		haptic()
 		closeAndFocus()
 	})
 
-	onTap(sendButton, (event: Event) => {
-		event.preventDefault()
+	onTap(sendButton, () => {
 		haptic()
 		void submit()
 	})

src/controls/floating-buttons.ts

@@ -25,8 +25,7 @@ function createGroupButton(
 	button.textContent = def.label
 	button.setAttribute('aria-label', def.description)
 
-	onTap(button, (e: Event) => {
-		e.preventDefault()
+	onTap(button, () => {
 		const kbWasOpen = isKeyboardOpen()
 		haptic()
 

src/controls/font-size.ts

@@ -31,14 +31,12 @@ export function createFontControls(term: XTerminal, font: FontConfig): FontContr
 	container.appendChild(btnPlus)
 	container.appendChild(btnHelp)
 
-	onTap(btnMinus, (e: Event) => {
-		e.preventDefault()
+	onTap(btnMinus, () => {
 		haptic()
 		changeFontSize(term, -2, font)
 	})
 
-	onTap(btnPlus, (e: Event) => {
-		e.preventDefault()
+	onTap(btnPlus, () => {
 		haptic()
 		changeFontSize(term, 2, font)
 	})

src/controls/help.ts

@@ -135,8 +135,7 @@ export function createHelpOverlay(
 		}
 	})
 
-	onTap(helpButton, (e: Event) => {
-		e.preventDefault()
+	onTap(helpButton, () => {
 		haptic()
 		open()
 	})

src/drawer/drawer.ts

@@ -46,8 +46,7 @@ export function createDrawer(
 	for (const buttonDef of buttons) {
 		const button = el('button')
 		button.textContent = buttonDef.label
-		onTap(button, (e: Event) => {
-			e.preventDefault()
+		onTap(button, () => {
 			const kbWasOpen = isKeyboardOpen()
 			haptic()
 			close()

src/toolbar/toolbar.ts

@@ -68,8 +68,7 @@ function wireButton(
 		readonly focusIfNeeded: () => void
 	}) => void,
 ): void {
-	onTap(button, (e: Event) => {
-		e.preventDefault()
+	onTap(button, () => {
 		const kbWasOpen = isKeyboardOpen()
 		haptic()
 

src/util/tap.ts

@@ -10,7 +10,10 @@ export function onTap(element: HTMLElement, handler: (e: Event) => void): void {
 	let touchFired = false
 
 	element.addEventListener('touchend', (e: TouchEvent) => {
-		e.preventDefault()
+		// No preventDefault — allow the browser to synthesise mousedown/click,
+		// which transfers focus to the button and away from the terminal textarea.
+		// Without this, Android re-shows the keyboard when buttons are pressed.
+		// The touchFired guard below prevents the handler from double-firing.
 		touchFired = true
 		handler(e)
 		setTimeout(() => {

tests/tap.test.ts

@@ -27,6 +27,14 @@ describe('onTap', () => {
 		expect(handler).toHaveBeenCalledOnce()
 	})
 
+	test('touchend does not call preventDefault', () => {
+		const element = document.createElement('button')
+		onTap(element, () => {})
+		const event = new TouchEvent('touchend')
+		element.dispatchEvent(event)
+		expect(event.defaultPrevented).toBe(false)
+	})
+
 	test('click fires again after guard timeout', () => {
 		vi.useFakeTimers()
 		const element = document.createElement('button')