Add PHP 8.5 to test matrices (php-tuf#401)

Author: star-szr

.github/workflows/build.yml

@@ -22,7 +22,7 @@ jobs:
       max-parallel: 10
       matrix:
         operating-system: [ubuntu-latest, macos-latest, windows-latest]
-        php: ['8.1', '8.2', '8.3', '8.4']
+        php: ['8.1', '8.2', '8.3', '8.4', '8.5']
         experimental: [false]
         include:
           - operating-system: ubuntu-latest

.github/workflows/drupal.yml

@@ -17,15 +17,17 @@ jobs:
       fail-fast: false
       max-parallel: 10
       matrix:
-        php: ['8.1', '8.2', '8.3', '8.4']
+        php: ['8.1', '8.2', '8.3', '8.4', '8.5']
         template:
           - recommended-project
           - legacy-project
         core: [10, 11]
-        # Drupal 11's minimum PHP version is 8.3.
         exclude:
+          # Drupal 11's minimum PHP version is 8.3.
           - { core: 11, php: 8.1 }
           - { core: 11, php: 8.2 }
+          # Drupal 10's maximum PHP version is 8.4.
+          - { core: 10, php: 8.5 }
 
     steps:
       - name: Checkout code

tests/ClientTestBase.php

@@ -94,11 +94,9 @@ protected function getUpdater(string $updaterClass = Updater::class): Updater
         // we control what time it is.
         $reflector = new \ReflectionObject($updater);
         $property = $reflector->getProperty('clock');
-        $property->setAccessible(true);
         $property->setValue($updater, new TestClock());
 
         $property = $reflector->getProperty('server');
-        $property->setAccessible(true);
         $property->setValue($updater, $this->serverMetadata);
 
         return $updater;

tests/SignatureVerifierTest.php

@@ -32,7 +32,6 @@ public function testCreateFromRootMetadata(): void
 
         $verifier = SignatureVerifier::createFromRootMetadata($rootMetadata);
         $verifierKeys = new \ReflectionProperty($verifier, 'keys');
-        $verifierKeys->setAccessible(true);
         $verifierKeys = $verifierKeys->getValue($verifier);
 
         // All of the root metadata keys should be loaded into the verifier.

tests/Unit/Client/VerifierTest.php

@@ -184,7 +184,6 @@ public function testCheckFreezeAttackNoAttack(): void
         $now = \DateTimeImmutable::createFromFormat($dateFormat, $nowString);
 
         $method = new \ReflectionMethod(VerifierBase::class, 'checkFreezeAttack');
-        $method->setAccessible(true);
 
         // The update's expiration is later than now, so no freeze attack
         // exception should be thrown.
@@ -223,7 +222,6 @@ public function testCheckFreezeAttackAttack(): void
         $now = \DateTimeImmutable::createFromFormat($dateFormat, '1970-01-01T00:00:01Z');
 
         $method = new \ReflectionMethod(VerifierBase::class, 'checkFreezeAttack');
-        $method->setAccessible(true);
 
         // The update has already expired, so a freeze attack exception should
         // be thrown.

tests/Unit/FileStorageTest.php

@@ -165,7 +165,6 @@ public function testFileNamesAreUrlEncoded(): void
         $this->assertFileExists($dir . '/' . $expectedFileName);
 
         $method = new \ReflectionMethod($storage, 'read');
-        $method->setAccessible(true);
         $this->assertSame($fileContents, $method->invoke($storage, $roleName));
     }
 }