-
Notifications
You must be signed in to change notification settings - Fork 22
Expand file tree
/
Copy pathExceptionDeclarationSniffTest.php
More file actions
174 lines (161 loc) · 6.16 KB
/
ExceptionDeclarationSniffTest.php
File metadata and controls
174 lines (161 loc) · 6.16 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
<?php
declare(strict_types = 1);
namespace Consistence\Sniffs\Exceptions;
use Generator;
class ExceptionDeclarationSniffTest extends \Consistence\Sniffs\TestCase
{
/**
* @return mixed[][]|\Generator
*/
public function validExceptionDeclarationDataProvider(): Generator
{
yield 'valid class name' => [
'filePath' => __DIR__ . '/data/ValidNameException.php',
];
yield 'valid class name that extends custom exception' => [
'filePath' => __DIR__ . '/data/ValidClassNameThatExtendsCustomException.php',
];
yield 'abstract exception with valid name' => [
'filePath' => __DIR__ . '/data/AbstractExceptionWithValidNameException.php',
];
yield 'class that does not extend anything' => [
'filePath' => __DIR__ . '/data/ClassThatDoesNotExtendAnything.php',
];
yield 'class that extends regular class' => [
'filePath' => __DIR__ . '/data/ClassThatDoesNotExtendException.php',
];
yield 'interface that does not extend anything' => [
'filePath' => __DIR__ . '/data/InterfaceThatDoesNotExtendAnything.php',
];
yield 'interface that does not extend anything exception' => [
'filePath' => __DIR__ . '/data/InterfaceThatDoesNotExtendAnythingException.php',
];
yield 'interface that extends exception' => [
'filePath' => __DIR__ . '/data/InterfaceThatExtendsException.php',
];
yield 'exception with chainable constructor is chainable' => [
'filePath' => __DIR__ . '/data/ChainableConstructorException.php',
];
yield 'exception with custom exception argument is chainable' => [
'filePath' => __DIR__ . '/data/CustomExceptionArgumentChainableConstructorException.php',
];
yield 'exception with error argument is chainable' => [
'filePath' => __DIR__ . '/data/ErrorArgumentChainableConstructorException.php',
];
yield 'exception is placed in correct directory' => [
'filePath' => __DIR__ . '/data/ValidNameException.php',
];
}
/**
* @dataProvider validExceptionDeclarationDataProvider
*
* @param string $filePath
*/
public function testValidExceptionDeclaration(string $filePath): void
{
$resultFile = $this->checkFile($filePath, [
'exceptionsDirectoryName' => 'data',
]);
$this->assertNoSniffErrorInFile($resultFile);
}
/**
* @return mixed[][]|\Generator
*/
public function invalidExceptionDeclarationDataProvider(): Generator
{
yield 'invalid exception name' => [
'filePath' => __DIR__ . '/data/InvalidExceptionName.php',
'exceptionsDirectoryName' => 'data',
'line' => 7,
'code' => ExceptionDeclarationSniff::CODE_NOT_ENDING_WITH_EXCEPTION,
'message' => 'Exception class name "InvalidExceptionName" must end with "Exception".',
];
yield 'abstract class with invalid exception name' => [
'filePath' => __DIR__ . '/data/AbstractExceptionWithInvalidName.php',
'exceptionsDirectoryName' => 'data',
'line' => 7,
'code' => ExceptionDeclarationSniff::CODE_NOT_ENDING_WITH_EXCEPTION,
'message' => 'Exception class name "AbstractExceptionWithInvalidName" must end with "Exception".',
];
yield 'interface that extends exception incorrect name' => [
'filePath' => __DIR__ . '/data/InterfaceThatExtendsExceptionIncorrectName.php',
'exceptionsDirectoryName' => 'data',
'line' => 7,
'code' => ExceptionDeclarationSniff::CODE_NOT_ENDING_WITH_EXCEPTION,
'message' => 'Exception class name "InterfaceThatExtendsExceptionIncorrectName" must end with "Exception".',
];
yield 'exception with constructor without parameters is not chainable' => [
'filePath' => __DIR__ . '/data/ConstructWithoutParametersException.php',
'exceptionsDirectoryName' => 'data',
'line' => 10,
'code' => ExceptionDeclarationSniff::CODE_NOT_CHAINABLE,
'message' => 'Exception is not chainable. It must have optional \Throwable as last constructor argument.',
];
yield 'exception with non-chainable constructor is not chainable' => [
'filePath' => __DIR__ . '/data/NonChainableConstructorException.php',
'exceptionsDirectoryName' => 'data',
'line' => 10,
'code' => ExceptionDeclarationSniff::CODE_NOT_CHAINABLE,
'message' => 'Exception is not chainable. It must have optional \Throwable as last constructor argument and has "string".',
];
yield 'exception with constructor without parameter type hint is not chainable' => [
'filePath' => __DIR__ . '/data/NonChainableConstructorWithoutParameterTypehintException.php',
'exceptionsDirectoryName' => 'data',
'line' => 10,
'code' => ExceptionDeclarationSniff::CODE_NOT_CHAINABLE,
'message' => 'Exception is not chainable. It must have optional \Throwable as last constructor argument and has none.',
];
yield 'exception is placed in incorrect directory' => [
'filePath' => __DIR__ . '/data/ValidNameException.php',
'exceptionsDirectoryName' => 'exceptions',
'line' => 7,
'code' => ExceptionDeclarationSniff::CODE_INCORRECT_EXCEPTION_DIRECTORY,
'message' => 'Exception file "ValidNameException.php" must be placed in "exceptions" directory (is in "data").',
];
yield 'exception is placed in incorrect directory case sensitively' => [
'filePath' => __DIR__ . '/data/ValidNameException.php',
'exceptionsDirectoryName' => 'Data',
'line' => 7,
'code' => ExceptionDeclarationSniff::CODE_INCORRECT_EXCEPTION_DIRECTORY,
'message' => 'Exception file "ValidNameException.php" must be placed in "Data" directory (is in "data").',
];
}
/**
* @dataProvider invalidExceptionDeclarationDataProvider
*
* @param string $filePath
* @param string $exceptionsDirectoryName
* @param int $line
* @param string $code
* @param string $message
*/
public function testInvalidExceptionDeclaration(
string $filePath,
string $exceptionsDirectoryName,
int $line,
string $code,
string $message
): void
{
$resultFile = $this->checkFile($filePath, [
'exceptionsDirectoryName' => $exceptionsDirectoryName,
]);
$this->assertSniffError(
$resultFile,
$line,
$code,
$message
);
}
/**
* @requires OS WIN
*/
public function testExceptionIsPlacedInCorrectDirectoryOnWindows(): void
{
// PHP_CodeSniffer detects the path with backslashes on Windows
$resultFile = $this->checkFile(__DIR__ . '\data\ValidNameException.php', [
'exceptionsDirectoryName' => 'data',
]);
$this->assertNoSniffErrorInFile($resultFile);
}
}