Skip to content

fix(project-context): Integrate PR #320 path fix and test hooks - #323

Merged
sylvansys merged 3 commits into
mainfrom
321-feature/can-u-integrate-changes-from-httpsgithub
Jan 31, 2026
Merged

fix(project-context): Integrate PR #320 path fix and test hooks#323
sylvansys merged 3 commits into
mainfrom
321-feature/can-u-integrate-changes-from-httpsgithub

Conversation

@sylvansys

Copy link
Copy Markdown
Collaborator

Summary

Changes

File: plugins/project-context/shared/hooks/utils/task-state.ts

Fixed the getTaskEdits function to correctly resolve parent transcript paths:

  • Agent transcripts: .../project/{sessionId}/subagents/agent-{agentId}.jsonl
  • Parent transcripts: .../project/{sessionId}.jsonl

The previous code only went up one directory level, causing "parent transcript not found" errors.

Test Results

Test Result
Fix applied and committed
PR #320 closed
Subagent receives context/rules
SubagentStart hooks fire ✅ (4x)
SubagentStop hooks fire ✅ (10x)
Subissue created ✅ (#322)

Test Plan

Closes #321

🤖 Generated with Claude Code

Agent transcripts are at .../project/{sessionId}/subagents/agent-{agentId}.jsonl
Parent transcripts are at .../project/{sessionId}.jsonl

The previous code incorrectly computed the parent path by only going up one
directory level. This fix properly navigates from the subagents/ directory
to the project root to find the parent transcript.

Integrates fix from PR #320.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jan 24, 2026

Copy link
Copy Markdown

Constellos Review - PR feedback from your reviewer agents.

Requirements: ❌ 0 • ❌ 0 • ⏭️ 0

View agent prompt

Code Quality: ✅ 4 • ❌ 0 • ⏭️ 0
Check Status Reasoning
DRY Compliance No significant code duplication found. Utility functions are well-factored and reusable (e.g., file path getters, git operations). Both files follow similar state management patterns appropriately for their different domains (stacked branches vs task state).
YAGNI Compliance Code implements only what's needed for the stacked PR workflow. No speculative features or over-engineering detected. The comprehensive documentation and type definitions serve the actual implementation needs.
Modularity Both files demonstrate excellent separation of concerns with clear logical sections (constants, types, state management, git operations, PR operations, cleanup). Functions are single-purpose and well-organized. The task-state module properly separates context persistence from transcript analysis.
Maintainability Code is highly maintainable with comprehensive JSDoc comments, clear function names, explicit types, and well-structured organization. Each function has a clear purpose, parameters are well-documented, and error handling is consistent. The section separators make navigation easy.

sylvansys and others added 2 commits January 24, 2026 13:21
The `gh pr create` command doesn't support `--json` flag.
Instead, parse the PR URL from stdout and extract the PR number.

Also use heredoc for body to handle multiline content properly.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Auto-generated from stacked PR workflow.

Files: 1 new, 1 edited, 0 deleted
@sylvansys
sylvansys merged commit c084708 into main Jan 31, 2026
@sylvansys
sylvansys deleted the 321-feature/can-u-integrate-changes-from-httpsgithub branch January 31, 2026 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plan: Integrate PR #320 and Test Hooks

1 participant