Skip to content

Commit c9ccaa0

Browse files
sylvansysclaude
andcommitted
fix: Quick fixes for reviewer comments
Phase 1 fixes from issue #56: - Use ⏭️ emoji for skipped status (instead of ⚠️) - Fix 404 agent prompt links by using SHA instead of branch name - Remove split test - use emoji format for all reviewers - Update intro line: "PR feedback updates from your reviewer agents..." - Add CI failure (exit 1) when checks fail Closes #56 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent acbd1e0 commit c9ccaa0

3 files changed

Lines changed: 18 additions & 12 deletions

File tree

.github/actions/code-quality-reviewer/action.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -197,3 +197,9 @@ runs:
197197
echo "checks_passed=$CHECKS_PASSED" >> $GITHUB_OUTPUT
198198
echo "checks_failed=$CHECKS_FAILED" >> $GITHUB_OUTPUT
199199
echo "checks_skipped=$CHECKS_SKIPPED" >> $GITHUB_OUTPUT
200+
201+
# Fail CI if any checks failed (but not if just skipped)
202+
if [ "$CHECKS_FAILED" -gt 0 ]; then
203+
echo "::error::$CHECKS_FAILED check(s) failed"
204+
exit 1
205+
fi

.github/actions/requirements-reviewer/action.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -250,3 +250,9 @@ runs:
250250
echo "checks_passed=$CHECKS_PASSED" >> $GITHUB_OUTPUT
251251
echo "checks_failed=$CHECKS_FAILED" >> $GITHUB_OUTPUT
252252
echo "checks_skipped=$CHECKS_SKIPPED" >> $GITHUB_OUTPUT
253+
254+
# Fail CI if any checks failed (but not if just skipped)
255+
if [ "$CHECKS_FAILED" -gt 0 ]; then
256+
echo "::error::$CHECKS_FAILED check(s) failed"
257+
exit 1
258+
fi

.github/actions/review-comment/action.yml

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -71,22 +71,16 @@ runs:
7171
STATUS_EMOJI="❌"
7272
else
7373
# All skipped
74-
STATUS_EMOJI="️"
74+
STATUS_EMOJI="️"
7575
fi
7676
77-
# Build summary line - split test: Requirements uses words only, others use emoji+number
78-
if [ "$REVIEW" = "Requirements" ]; then
79-
# Format A: Words only (no emoji)
80-
SUMMARY_PARTS="$CHECKS_PASSED passed • $CHECKS_FAILED failed • $CHECKS_SKIPPED skipped"
81-
else
82-
# Format B: Emoji + number only (compact)
83-
SUMMARY_PARTS="✅ $CHECKS_PASSED • ❌ $CHECKS_FAILED • ⚠️ $CHECKS_SKIPPED"
84-
fi
77+
# Build summary line with emojis
78+
SUMMARY_PARTS="✅ $CHECKS_PASSED • ❌ $CHECKS_FAILED • ⏭️ $CHECKS_SKIPPED"
8579
8680
# Build prompt link
8781
PROMPT_LINK=""
8882
if [ -n "$PROMPT_FILE" ]; then
89-
PROMPT_LINK="[View agent prompt](https://github.com/${{ github.repository }}/blob/${{ github.head_ref || github.ref_name }}/$PROMPT_FILE)"
83+
PROMPT_LINK="[View agent prompt](https://github.com/${{ github.repository }}/blob/${{ inputs.sha }}/$PROMPT_FILE)"
9084
fi
9185
9286
# Build checks table header
@@ -105,7 +99,7 @@ runs:
10599
case "$CHECK_STATUS" in
106100
"passed") CHECK_EMOJI="✅" ;;
107101
"failed") CHECK_EMOJI="❌" ;;
108-
*) CHECK_EMOJI="️" ;;
102+
*) CHECK_EMOJI="️" ;;
109103
esac
110104
111105
# Get files for this check
@@ -194,7 +188,7 @@ runs:
194188
# Create new comment
195189
{
196190
echo "$MARKER"
197-
echo "PR review updates from your Constellos agents. Based on linked issue(s), context files, and committed changes."
191+
echo "PR feedback updates from your reviewer agents. Based on linked issues, context files, and committed changes."
198192
echo ""
199193
echo "$AGENT_BLOCK"
200194
} > /tmp/comment.md

0 commit comments

Comments
 (0)