Skip to content

Commit e6437e2

Browse files
sylvansysclaude
andauthored
Fix CI workflow shell script and Playwright errors (#13)
- Remove invalid --screenshot=on option from Playwright E2E test command - Fix multi-line string assignments in all 4 review jobs (requirements, code-quality, context, ui) that caused shell parsing errors - Use printf for simple string concatenation - Use heredocs for multi-line comment templates Fixes "Requirements: command not found" and "exist: command not found" errors caused by YAML indentation issues in multi-line shell strings. Closes #12 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
1 parent eed68d7 commit e6437e2

2 files changed

Lines changed: 26 additions & 18 deletions

File tree

.github/workflows/ci-pipeline.yml

Lines changed: 25 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ jobs:
193193
- name: Run E2E tests
194194
run: |
195195
mkdir -p .claude/screenshots
196-
npx playwright test --project=chromium --screenshot=on
196+
npx playwright test --project=chromium
197197
198198
- uses: actions/upload-artifact@v4
199199
if: always()
@@ -297,20 +297,22 @@ jobs:
297297
OLD_BODY=$(echo "$EXISTING" | jq -r '.body')
298298
# Append new row
299299
NEW_BODY=$(echo "$OLD_BODY" | sed "/^| $REVIEW |/d")
300-
NEW_BODY="$NEW_BODY
301-
$ROW"
300+
NEW_BODY=$(printf '%s\n%s' "$NEW_BODY" "$ROW")
302301
gh api --method PATCH "/repos/${{ github.repository }}/issues/comments/$COMMENT_ID" -f body="$NEW_BODY"
303302
else
304303
# Create new comment
305-
COMMENT="$MARKER
304+
COMMENT=$(cat <<EOF
305+
$MARKER
306306
## Reviews
307307
308308
| Review | Status | Summary |
309309
|--------|--------|---------|
310310
$ROW
311311
312312
---
313-
*Claude Code CI*"
313+
*Claude Code CI*
314+
EOF
315+
)
314316
gh pr comment "$PR" --body "$COMMENT"
315317
fi
316318
@@ -386,20 +388,22 @@ jobs:
386388
COMMENT_ID=$(echo "$EXISTING" | jq -r '.id')
387389
OLD_BODY=$(echo "$EXISTING" | jq -r '.body')
388390
# Append new row before the footer
389-
NEW_BODY=$(echo "$OLD_BODY" | sed "/---/i\\
390-
$ROW")
391+
NEW_BODY=$(echo "$OLD_BODY" | sed "/---/i\\$ROW")
391392
gh api --method PATCH "/repos/${{ github.repository }}/issues/comments/$COMMENT_ID" -f body="$NEW_BODY"
392393
else
393394
# Create new comment (shouldn't happen as requirements runs first)
394-
COMMENT="$MARKER
395+
COMMENT=$(cat <<EOF
396+
$MARKER
395397
## Reviews
396398
397399
| Review | Status | Summary |
398400
|--------|--------|---------|
399401
$ROW
400402
401403
---
402-
*Claude Code CI*"
404+
*Claude Code CI*
405+
EOF
406+
)
403407
gh pr comment "$PR" --body "$COMMENT"
404408
fi
405409
@@ -499,20 +503,22 @@ jobs:
499503
COMMENT_ID=$(echo "$EXISTING" | jq -r '.id')
500504
OLD_BODY=$(echo "$EXISTING" | jq -r '.body')
501505
# Append new row before the footer
502-
NEW_BODY=$(echo "$OLD_BODY" | sed "/---/i\\
503-
$ROW")
506+
NEW_BODY=$(echo "$OLD_BODY" | sed "/---/i\\$ROW")
504507
gh api --method PATCH "/repos/${{ github.repository }}/issues/comments/$COMMENT_ID" -f body="$NEW_BODY"
505508
else
506509
# Create new comment (shouldn't happen as requirements runs first)
507-
COMMENT="$MARKER
510+
COMMENT=$(cat <<EOF
511+
$MARKER
508512
## Reviews
509513
510514
| Review | Status | Summary |
511515
|--------|--------|---------|
512516
$ROW
513517
514518
---
515-
*Claude Code CI*"
519+
*Claude Code CI*
520+
EOF
521+
)
516522
gh pr comment "$PR" --body "$COMMENT"
517523
fi
518524
@@ -602,19 +608,21 @@ jobs:
602608
COMMENT_ID=$(echo "$EXISTING" | jq -r '.id')
603609
OLD_BODY=$(echo "$EXISTING" | jq -r '.body')
604610
# Append new row before the footer
605-
NEW_BODY=$(echo "$OLD_BODY" | sed "/---/i\\
606-
$ROW")
611+
NEW_BODY=$(echo "$OLD_BODY" | sed "/---/i\\$ROW")
607612
gh api --method PATCH "/repos/${{ github.repository }}/issues/comments/$COMMENT_ID" -f body="$NEW_BODY"
608613
else
609614
# Create new comment (shouldn't happen as requirements runs first)
610-
COMMENT="$MARKER
615+
COMMENT=$(cat <<EOF
616+
$MARKER
611617
## Reviews
612618
613619
| Review | Status | Summary |
614620
|--------|--------|---------|
615621
$ROW
616622
617623
---
618-
*Claude Code CI*"
624+
*Claude Code CI*
625+
EOF
626+
)
619627
gh pr comment "$PR" --body "$COMMENT"
620628
fi

PLAN.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
/home/ben/.claude/plans/compiled-puzzling-crane.md
1+
/home/ben/.claude/plans/robust-tickling-starlight.md

0 commit comments

Comments
 (0)