Skip to content

Commit eed68d7

Browse files
sylvansysclaude
andauthored
Restructure CI reviews: 4 composite actions with requirements gate (#11)
* Session work\n\nAuto-commit at session end to preserve work in progress.\n\nSession-ID: 667d5a5c-c36b-4543-bfec-65936b7a6417\nSession-Timestamp: 2026-01-03T18:33:59.266Z\nBranch: claude-upbeat-bandicoot-ul46xpp5\n\n🤖 Generated with [Claude Code](https://claude.com/claude-code)\n\nCo-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * Restructure CI to exactly 3 checks: Static Analysis, Tests, Reviews - Delete old workflows (basic-ci.yml, ci.yml, e2e-tests.yml, deployment-ci.yml) - Delete old fragmented composite actions - Create 3 clean composite actions: - static-analysis: Lint (ESLint) + Types (TypeScript) - tests: Unit (Vitest) + E2E (Playwright, only if has_app) - reviews: Requirements (gate), Code Quality, Context, UI - Rewrite ci-pipeline.yml with only 3 jobs - Context Review now only checks CLAUDE.md files that are parents of changed files - Reviews post single consolidated comment Dependency chain: Static Analysis → Tests → Reviews 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Restructure CI with proper check naming Checks now appear as: - CI / Static Analysis / Lint (ESLint) - CI / Static Analysis / Types (TypeScript) - CI / Tests / Unit (Vitest) - CI / Tests / E2E (Playwright) [disabled for non-app repos] - CI / Reviews / Requirements - CI / Reviews / Code Quality - CI / Reviews / Context - CI / Reviews / UI [disabled for non-app repos] - CI / Reviews / Summary Dependencies: - Unit tests require Static Analysis to pass - E2E requires Unit to pass - Reviews require Unit to pass - Code Quality & Context require Requirements to pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Add dynamic app detection and update review dependencies - Add app detection step to lint job (checks for next.config, vite.config, playwright.config, apps/, src/app/) - E2E tests now only run when app is detected - Requirements review now depends on both unit and e2e tests - UI review now only runs when app is detected 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * PR-only CI with auto package manager detection - Remove push trigger to avoid duplicate checks - Auto-detect package manager (bun/npm/pnpm/yarn) from lockfile - Each review job incrementally builds a single PR comment - Remove separate summary job - Add minimal bun setup with typescript, eslint, vitest 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Fix bun lockfile detection for text format Bun now generates bun.lock (text) instead of bun.lockb (binary). Check for both formats. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Include root ts files in tsconfig Fix ESLint error: vitest.config.ts was not in project 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Pass unit tests when no test files exist Add --passWithNoTests flag to vitest 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 50b2419 commit eed68d7

16 files changed

Lines changed: 957 additions & 4035 deletions

.github/actions/consolidate-comment/action.yml

Lines changed: 0 additions & 507 deletions
This file was deleted.

.github/ci-config.yml

Lines changed: 17 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,38 +1,26 @@
11
# CI Configuration
2-
# Controls which CI workflows run in this repository
2+
# Template for Claude Code repos
33

44
ci:
5-
# Basic CI (always enabled)
6-
basic:
7-
enabled: true
5+
# Set to true if this repo has an app (enables E2E + UI review)
6+
has_app: false
7+
8+
# Static Analysis: Lint (ESLint) + Types (TypeScript)
9+
static_analysis:
810
lint: true
911
typecheck: true
10-
vitest: true
1112

12-
# E2E Testing
13-
e2e:
14-
enabled: true
15-
framework: playwright
13+
# Tests: Unit (Vitest) + E2E (Playwright)
14+
# E2E only runs if has_app: true
15+
tests:
16+
unit: true
17+
e2e: true
1618

17-
# Code Reviews (runs on every commit)
19+
# Reviews: Requirements, Code Quality, Context, UI
20+
# Requirements must pass before others run
21+
# UI only runs if has_app: true and screenshots exist
1822
reviews:
19-
enabled: true
2023
requirements: true
21-
rules: true
22-
project_memory: true
23-
agents: true
24-
skills: true
25-
playwright_ui: true
26-
27-
# Deployment CI (PR only)
28-
deployment:
29-
enabled: false
30-
31-
vercel:
32-
enabled: false
33-
34-
supabase:
35-
enabled: false
36-
37-
cloudflare:
38-
enabled: false
24+
code_quality: true
25+
context: true
26+
ui: true

.github/workflows/basic-ci.yml

Lines changed: 0 additions & 63 deletions
This file was deleted.

0 commit comments

Comments
 (0)