Skip to content

Status Report & Fixes Plan #32

Description

@sylvansys

Branch: 32-fix/can-u-tell-me-the-current-status-of-the-
Plan file: /home/ben/.claude/plans/noble-jumping-lerdorf.md


Status Report & Fixes Plan

Current Status of Actions Flow & App

Repository Type

This is NOT an application - it's a GitHub Actions marketplace package containing 9 reusable actions for AI-powered code reviews.

Structure

  • Root Action (action.yml): Dispatcher/router for simplified usage
  • 8 Composite Actions (.github/actions/):
    1. requirements-reviewer - Reviews PR changes against GitHub issue requirements
    2. code-quality-reviewer - Evaluates DRY, YAGNI, modularity principles
    3. context-reviewer - Validates changes against CLAUDE.md context files
    4. visual-reviewer - Analyzes UI screenshots for design/accessibility
    5. ux-reviewer - Reviews UX patterns and detects console errors
    6. hooks-reviewer - Reviews Claude Code hook configurations
    7. review-comment - Manages consolidated PR comments with collapsible sections
    8. changed-files - Smart file change detection for efficient CI
    9. capture-routes - Discovers Playwright routes and captures screenshots

Active Maintenance Status

ACTIVE - This repo is the source of truth for these actions:

  • Single workflow: test-actions.yml validates action metadata on push to main
  • Actions are consumed by org-level reusable workflows in constellos/.github
  • Template configurations exist in .github/templates/ for different deployment types

Org-Level Integration

The actions are integrated at the org level via:

  • Reusable workflow: constellos/.github/.github/workflows/ci-pipeline-reusable.yml
  • Pattern: Individual repos call the org-level reusable workflow
  • Location: https://github.com/constellos/.github

nodes-md PR Review

Search Results

No recent PRs mentioning "nodes-md" in this repository (search returned empty).

Context from Open Issues

However, Issue #18 ("CI Pipeline Issues & Fixes Plan") provides critical context:

Problem Identified:

  • nodes-md uses an OLD inline workflow with /tmp/ paths
  • Claude Code base action blocks /tmp access due to sandboxing
  • Causes "Unable to access required files" errors and 5-minute stalls

Status:

  • This repo (claude-code-actions) has the NEW version using .claude/review-context/ paths ✅
  • nodes-md has the OLD version using /tmp/ paths ❌

Outstanding Issue:

  • nodes-md needs workflow updated to match latest version from this repo
  • Issue CI Pipeline Issues & Fixes Plan #18 proposes moving to org-level reusable workflows to prevent version drift

CI Naming Issue: "CI / ci / Status Checks"

Root Cause

The duplication comes from the recommended pattern in README.md (lines 405-414):

name: CI           # ← Creates "CI" prefix
on: [pull_request]

jobs:
  ci:              # ← Creates "ci" prefix
    uses: constellos/.github/.github/workflows/ci-pipeline-reusable.yml@main

This creates the hierarchy:

  • Workflow name: "CI"
  • Job name: "ci"
  • Check names from reusable workflow: "Static Analysis / Lint", etc.

Result: Status checks appear as "CI / ci / Static Analysis / Lint"

Fix Location

Need to update:

  1. README.md:405-414 - Example code for individual repos
  2. Any existing repos using this pattern (like nodes-md, etc.)
  3. .github/templates/*.yml - If they contain workflow examples

Recommended Fix

Change the job name from ci to something descriptive or omit the redundant level:

Option 1: Descriptive job name

name: CI
on: [pull_request]

jobs:
  pipeline:  # Changed from "ci" to "pipeline"
    uses: constellos/.github/.github/workflows/ci-pipeline-reusable.yml@main

Result: "CI / pipeline / Static Analysis / Lint"

Option 2: Remove redundancy (RECOMMENDED)

name: CI Pipeline
on: [pull_request]

jobs:
  checks:  # Single word, clear purpose
    uses: constellos/.github/.github/workflows/ci-pipeline-reusable.yml@main

Result: "CI Pipeline / checks / Static Analysis / Lint"

Option 3: Flat hierarchy

name: Status Checks
on: [pull_request]

jobs:
  run:
    uses: constellos/.github/.github/workflows/ci-pipeline-reusable.yml@main

Result: "Status Checks / run / Static Analysis / Lint"

Implementation Plan

Files to Modify

In this repo (claude-code-actions):

  1. README.md:405-414 - Fix example code for calling reusable workflow
  2. Verify .github/templates/ doesn't contain workflow examples (only config templates)

Documentation to create:
3. Add a section in README explaining proper workflow naming conventions

Changes Required

README.md (lines 405-414):

# BEFORE
name: CI
on: [pull_request]

jobs:
  ci:
    uses: constellos/.github/.github/workflows/ci-pipeline-reusable.yml@main

# AFTER
name: Status Checks
on: [pull_request]

jobs:
  run:
    uses: constellos/.github/.github/workflows/ci-pipeline-reusable.yml@main
    with:
      actions_version: 'v1.0.0'
    secrets: inherit

Add new section after line 414:

### Status Check Naming

GitHub creates a hierarchy from:
1. Workflow name (e.g., "Status Checks")
2. Job name (e.g., "run")
3. Check names from reusable workflow (e.g., "Static Analysis / Lint")

**Result**: "Status Checks / run / Static Analysis / Lint"

**Best practices:**
- Use descriptive workflow names without "CI" prefix if job uses word "ci"
- Keep job names short and meaningful
- Avoid redundant terms (don't name workflow "CI" and job "ci")

Verification

After changes:

  1. Check README renders correctly in GitHub
  2. Verify templates in .github/templates/ are config-only (not workflow files)
  3. Create example PR in a test repo to confirm naming appears as expected
  4. Update documentation in constellos/.github repo if needed

Summary

Component Status Action Needed
Actions flow ✅ Active None - working as designed
App component ❌ N/A This is not an app, it's a GitHub Actions package
nodes-md PRs ⚠️ No recent PRs found Check nodes-md repo directly for issues
nodes-md workflow ❌ Using old version See Issue #18 for fix plan
CI naming ❌ Duplicated Fix README example and add naming docs
Org integration ✅ Active constellos/.github has reusable workflows

Critical Files

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions