Skip to content

extract-result.sh reports failed checks when all checks pass #70

Description

@sylvansys

Description

The extract-result.sh script in the code-quality reviewer incorrectly reports failed checks even when all checks pass.

Evidence

From PR constellos/constellos#57, run 21466036077:

PR Comment shows:

Code Quality: ✅ 4 • ❌ 0 • ⏭️ 0

All 4 checks passed:

  • DRY Compliance ✅
  • YAGNI Compliance ✅
  • Modularity ✅
  • Maintainability ✅

But CI output shows:

##[error]2 check(s) failed
##[error]Process completed with exit code 1.

Root Cause

The extract-result.sh script is parsing the Claude response incorrectly. It's extracting the wrong count for CHECKS_FAILED.

Expected Behavior

When all checks show ✅ in the response, CHECKS_FAILED should be 0 and the job should pass.

Impact

PRs that pass all code quality checks are being incorrectly marked as failed, blocking merges.

🤖 Generated with Claude Code

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions