Restructure CI reviews: 4 composite actions with requirements gate - #11
Merged
Conversation
…ss.\n\nSession-ID: 667d5a5c-c36b-4543-bfec-65936b7a6417\nSession-Timestamp: 2026-01-03T18:33:59.266Z\nBranch: claude-upbeat-bandicoot-ul46xpp5\n\n🤖 Generated with [Claude Code](https://claude.com/claude-code)\n\nCo-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Code Review ResultsCommit: Requirements Review -- SkippedNo linked issue found or no requirements to verify. UI Review -- SkippedNo UI files changed or no screenshots available. Code Quality Review -- SkippedNo code files changed. Context Review -- SkippedNo context files to review. Automated by Claude Code CI |
- Delete old workflows (basic-ci.yml, ci.yml, e2e-tests.yml, deployment-ci.yml) - Delete old fragmented composite actions - Create 3 clean composite actions: - static-analysis: Lint (ESLint) + Types (TypeScript) - tests: Unit (Vitest) + E2E (Playwright, only if has_app) - reviews: Requirements (gate), Code Quality, Context, UI - Rewrite ci-pipeline.yml with only 3 jobs - Context Review now only checks CLAUDE.md files that are parents of changed files - Reviews post single consolidated comment Dependency chain: Static Analysis → Tests → Reviews 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Checks now appear as: - CI / Static Analysis / Lint (ESLint) - CI / Static Analysis / Types (TypeScript) - CI / Tests / Unit (Vitest) - CI / Tests / E2E (Playwright) [disabled for non-app repos] - CI / Reviews / Requirements - CI / Reviews / Code Quality - CI / Reviews / Context - CI / Reviews / UI [disabled for non-app repos] - CI / Reviews / Summary Dependencies: - Unit tests require Static Analysis to pass - E2E requires Unit to pass - Reviews require Unit to pass - Code Quality & Context require Requirements to pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add app detection step to lint job (checks for next.config, vite.config, playwright.config, apps/, src/app/) - E2E tests now only run when app is detected - Requirements review now depends on both unit and e2e tests - UI review now only runs when app is detected 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Remove push trigger to avoid duplicate checks - Auto-detect package manager (bun/npm/pnpm/yarn) from lockfile - Each review job incrementally builds a single PR comment - Remove separate summary job - Add minimal bun setup with typescript, eslint, vitest 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Bun now generates bun.lock (text) instead of bun.lockb (binary). Check for both formats. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Fix ESLint error: vitest.config.ts was not in project 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add --passWithNoTests flag to vitest 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Reviews
Claude Code CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
New Composite Actions
.github/actions/requirements-review/- Gate review checking issue requirements.github/actions/ui-review/- Playwright screenshot analysis.github/actions/code-quality-review/- Code quality principles (DRY, YAGNI, modularity, complexity, coupling, cohesion).github/actions/context-review/- 4 parallel Claude calls for rules, project memory, agents, skillsModified Files
.github/workflows/ci-pipeline.yml- Refactored to use composite actions with proper dependency chain.github/actions/consolidate-comment/action.yml- Updated for 4-review structure.github/ci-config.yml- New configuration structureDeleted Files
.github/workflows/reviews.yml- Replaced by composite actions.github/workflows/playwright-ui-review.yml- Absorbed into ui-reviewDependency Chain
Test plan
Closes #10
🤖 Generated with Claude Code