Skip to content

Fix CI heredoc errors, add Visual/UX reviewers & composite actions - #17

Merged
sylvansys merged 4 commits into
mainfrom
claude-elegant-falcon-hlwid2wp
Jan 5, 2026
Merged

Fix CI heredoc errors, add Visual/UX reviewers & composite actions#17
sylvansys merged 4 commits into
mainfrom
claude-elegant-falcon-hlwid2wp

Conversation

@sylvansys

@sylvansys sylvansys commented Jan 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fixed shell heredoc syntax errors in CI pipeline that caused "Requirements: command not found"
  • Renamed UI review to Visual (Reviews / Visual)
  • Added UX review job (Reviews / UX) for console errors and behavioral issues
  • Created 7 composite actions for reusable CI review components
  • Created 5 agent prompt files in .claude/agents/reviewers/

Changes

Bug Fix

Fixed 4 broken heredoc blocks in ci-pipeline.yml (lines 307-318, 400-412, 518-530, 623-635) by replacing with printf.

New Composite Actions

.github/actions/
├── review-comment/          # Shared PR comment update logic
├── requirements-reviewer/   # Checks PR against issue requirements
├── code-quality-reviewer/   # Evaluates DRY, YAGNI, modularity
├── context-reviewer/        # Checks CLAUDE.md compliance
├── capture-routes/          # Discovers Playwright routes, captures screenshots
├── visual-reviewer/         # Reviews screenshots with regression detection
└── ux-reviewer/             # Analyzes UX issues and console errors

Agent Prompt Files

.claude/agents/reviewers/
├── requirements.md
├── code-quality.md
├── context.md
├── visual.md
└── ux.md

Usage from Other Repos

uses: constellos/claude-code-actions/.github/actions/visual-reviewer@v1

Test plan

  • CI pipeline runs without shell errors
  • Requirements review passes and dependent reviews fire
  • UX review job executes for UI-related file changes
  • Composite actions are accessible from other repos

Closes #16

🤖 Generated with Claude Code

@sylvansys
Session work\n\nAuto-commit at session end to preserve work in progre…
0285b1e 
…ss.\n\nSession-ID: 73c6099a-bea4-474a-9eb9-7e6ddc757858\nSession-Timestamp: 2026-01-05T02:36:00.084Z\nBranch: claude-elegant-falcon-hlwid2wp\n\n🤖 Generated with [Claude Code](https://claude.com/claude-code)\n\nCo-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jan 5, 2026

Copy link
Copy Markdown

Reviews

Review Status Summary
Requirements ✓ Comprehensive CI pipeline implemented with static analysis, testing, and multi-stage reviews. Includes lint/typecheck, unit/E2E tests, and 5 specialized review agents (requirements, code quality, context, visual, UX). Supports multiple package managers (npm/yarn/pnpm/bun) with proper dependency detection. All review results are consolidated into PR comments for clear feedback.

Claude Code CI

@sylvansys sylvansys mentioned this pull request Jan 5, 2026
Closed
7 tasks
@sylvansys @claude
Fix CI output propagation & refactor to composite actions
6ee986c 
- Fix all 5 reviewer actions to always set outputs (no early exit)
- Refactor ci-pipeline.yml to use composite actions instead of inline logic
- Change dependent job conditions to use needs.X.result == 'success'
- Reduce workflow from ~700 lines to 375 lines

Closes #16

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jan 5, 2026

Copy link
Copy Markdown

Reviews

Review Status Summary
Requirements ✗

Claude Code CI

@sylvansys @claude
Fix YAML indentation in composite action prompts
974b7f4 
YAML literal blocks require all content lines to be indented.
Simplified inline fallback prompts to avoid multiline content.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jan 5, 2026

Copy link
Copy Markdown

Reviews

Review Status Summary
Requirements ✗

Claude Code CI

@sylvansys @claude
Add always() to review job conditions to fix job skipping
d5cf2e8 
GitHub Actions skips dependent jobs by default when any `needs` dependency
was skipped (even if the direct dependency succeeded). The `if` condition
isn't evaluated unless we explicitly add `always()`.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jan 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Reviews

Review Status Summary
Requirements ✗

| Context | ✓ | No CLAUDE.md files to check |
| Code Quality | ✗ | |

Claude Code CI

@sylvansys
sylvansys merged commit 1dd28eb into main Jan 5, 2026
9 checks passed
@sylvansys
sylvansys deleted the claude-elegant-falcon-hlwid2wp branch January 5, 2026 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI Reviews Enhancement Plan (v2)

1 participant

@sylvansys